Skip to content

Commit a6b4e29

Browse files
jhuber6jhuber6
authored
[libc] Re-enable several GPU math smoke tests (#83147)
Summary: These were originally disabled after some changes caused them to regress. It seems that whatever broke them the first time a few months ago has been fixed elsewhere and they now work again. Re-enable all the ones that work. There are still a few that we need to look into, but this is a good start.
1 parent ed35ad1 commit a6b4e29

File tree

1 file changed

+0
-76
lines changed

1 file changed

+0
-76
lines changed

‎libc/test/src/math/smoke/CMakeLists.txt

Lines changed: 0 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,6 @@ add_fp_unittest(
6565
libc.include.math
6666
libc.src.math.fabs
6767
libc.src.__support.FPUtil.fp_bits
68-
# FIXME: Currently fails on the GPU build.
69-
UNIT_TEST_ONLY
7068
)
7169

7270
add_fp_unittest(
@@ -81,14 +79,10 @@ add_fp_unittest(
8179
libc.include.math
8280
libc.src.math.fabsf
8381
libc.src.__support.FPUtil.fp_bits
84-
# FIXME: Currently fails on the GPU build.
85-
UNIT_TEST_ONLY
8682
)
8783

8884
add_fp_unittest(
8985
fabsl_test
90-
# FIXME: Currently fails on the GPU build.
91-
UNIT_TEST_ONLY
9286
SUITE
9387
libc-math-smoke-tests
9488
SRCS
@@ -103,8 +97,6 @@ add_fp_unittest(
10397

10498
add_fp_unittest(
10599
fabsf128_test
106-
# FIXME: Currently fails on the GPU build.
107-
UNIT_TEST_ONLY
108100
SUITE
109101
libc-math-smoke-tests
110102
SRCS
@@ -129,8 +121,6 @@ add_fp_unittest(
129121
libc.include.math
130122
libc.src.math.trunc
131123
libc.src.__support.FPUtil.fp_bits
132-
# FIXME: Currently fails on the GPU build.
133-
UNIT_TEST_ONLY
134124
)
135125

136126
add_fp_unittest(
@@ -145,8 +135,6 @@ add_fp_unittest(
145135
libc.include.math
146136
libc.src.math.truncf
147137
libc.src.__support.FPUtil.fp_bits
148-
# FIXME: Currently fails on the GPU build.
149-
UNIT_TEST_ONLY
150138
)
151139

152140
add_fp_unittest(
@@ -161,8 +149,6 @@ add_fp_unittest(
161149
libc.include.math
162150
libc.src.math.truncl
163151
libc.src.__support.FPUtil.fp_bits
164-
# FIXME: Currently fails on the GPU build.
165-
UNIT_TEST_ONLY
166152
)
167153

168154
add_fp_unittest(
@@ -177,8 +163,6 @@ add_fp_unittest(
177163
libc.include.math
178164
libc.src.math.truncf128
179165
libc.src.__support.FPUtil.fp_bits
180-
# FIXME: Currently fails on the GPU build.
181-
UNIT_TEST_ONLY
182166
)
183167

184168
add_fp_unittest(
@@ -193,8 +177,6 @@ add_fp_unittest(
193177
libc.include.math
194178
libc.src.math.ceil
195179
libc.src.__support.FPUtil.fp_bits
196-
# FIXME: Currently fails on the GPU build.
197-
UNIT_TEST_ONLY
198180
)
199181

200182
add_fp_unittest(
@@ -209,8 +191,6 @@ add_fp_unittest(
209191
libc.include.math
210192
libc.src.math.ceilf
211193
libc.src.__support.FPUtil.fp_bits
212-
# FIXME: Currently fails on the GPU build.
213-
UNIT_TEST_ONLY
214194
)
215195

216196
add_fp_unittest(
@@ -225,8 +205,6 @@ add_fp_unittest(
225205
libc.include.math
226206
libc.src.math.ceill
227207
libc.src.__support.FPUtil.fp_bits
228-
# FIXME: Currently fails on the GPU build.
229-
UNIT_TEST_ONLY
230208
)
231209

232210
add_fp_unittest(
@@ -241,8 +219,6 @@ add_fp_unittest(
241219
libc.include.math
242220
libc.src.math.ceilf128
243221
libc.src.__support.FPUtil.fp_bits
244-
# FIXME: Currently fails on the GPU build.
245-
UNIT_TEST_ONLY
246222
)
247223

248224
add_fp_unittest(
@@ -257,8 +233,6 @@ add_fp_unittest(
257233
libc.include.math
258234
libc.src.math.floor
259235
libc.src.__support.FPUtil.fp_bits
260-
# FIXME: Currently fails on the GPU build.
261-
UNIT_TEST_ONLY
262236
)
263237

264238
add_fp_unittest(
@@ -273,8 +247,6 @@ add_fp_unittest(
273247
libc.include.math
274248
libc.src.math.floorf
275249
libc.src.__support.FPUtil.fp_bits
276-
# FIXME: Currently fails on the GPU build.
277-
UNIT_TEST_ONLY
278250
)
279251

280252
add_fp_unittest(
@@ -289,8 +261,6 @@ add_fp_unittest(
289261
libc.include.math
290262
libc.src.math.floorl
291263
libc.src.__support.FPUtil.fp_bits
292-
# FIXME: Currently fails on the GPU build.
293-
UNIT_TEST_ONLY
294264
)
295265

296266
add_fp_unittest(
@@ -305,8 +275,6 @@ add_fp_unittest(
305275
libc.include.math
306276
libc.src.math.floorf128
307277
libc.src.__support.FPUtil.fp_bits
308-
# FIXME: Currently fails on the GPU build.
309-
UNIT_TEST_ONLY
310278
)
311279

312280
add_fp_unittest(
@@ -321,8 +289,6 @@ add_fp_unittest(
321289
libc.include.math
322290
libc.src.math.round
323291
libc.src.__support.FPUtil.fp_bits
324-
# FIXME: Currently fails on the GPU build.
325-
UNIT_TEST_ONLY
326292
)
327293

328294
add_fp_unittest(
@@ -337,8 +303,6 @@ add_fp_unittest(
337303
libc.include.math
338304
libc.src.math.roundf
339305
libc.src.__support.FPUtil.fp_bits
340-
# FIXME: Currently fails on the GPU build.
341-
UNIT_TEST_ONLY
342306
)
343307

344308
add_fp_unittest(
@@ -353,8 +317,6 @@ add_fp_unittest(
353317
libc.include.math
354318
libc.src.math.roundl
355319
libc.src.__support.FPUtil.fp_bits
356-
# FIXME: Currently fails on the GPU build.
357-
UNIT_TEST_ONLY
358320
)
359321

360322
add_fp_unittest(
@@ -369,8 +331,6 @@ add_fp_unittest(
369331
libc.include.math
370332
libc.src.math.roundf128
371333
libc.src.__support.FPUtil.fp_bits
372-
# FIXME: Currently fails on the GPU build.
373-
UNIT_TEST_ONLY
374334
)
375335

376336
add_fp_unittest(
@@ -389,8 +349,6 @@ add_fp_unittest(
389349
libc.src.fenv.fetestexcept
390350
libc.src.math.lround
391351
libc.src.__support.FPUtil.fp_bits
392-
# FIXME: Currently fails on the GPU build.
393-
UNIT_TEST_ONLY
394352
)
395353

396354
add_fp_unittest(
@@ -409,8 +367,6 @@ add_fp_unittest(
409367
libc.src.fenv.fetestexcept
410368
libc.src.math.lroundf
411369
libc.src.__support.FPUtil.fp_bits
412-
# FIXME: Currently fails on the GPU build.
413-
UNIT_TEST_ONLY
414370
)
415371

416372
add_fp_unittest(
@@ -429,8 +385,6 @@ add_fp_unittest(
429385
libc.src.fenv.fetestexcept
430386
libc.src.math.lroundl
431387
libc.src.__support.FPUtil.fp_bits
432-
# FIXME: Currently fails on the GPU build.
433-
UNIT_TEST_ONLY
434388
)
435389

436390
add_fp_unittest(
@@ -449,8 +403,6 @@ add_fp_unittest(
449403
libc.src.fenv.fetestexcept
450404
libc.src.math.llround
451405
libc.src.__support.FPUtil.fp_bits
452-
# FIXME: Currently fails on the GPU build.
453-
UNIT_TEST_ONLY
454406
)
455407

456408
add_fp_unittest(
@@ -469,8 +421,6 @@ add_fp_unittest(
469421
libc.src.fenv.fetestexcept
470422
libc.src.math.llroundf
471423
libc.src.__support.FPUtil.fp_bits
472-
# FIXME: Currently fails on the GPU build.
473-
UNIT_TEST_ONLY
474424
)
475425

476426
add_fp_unittest(
@@ -489,8 +439,6 @@ add_fp_unittest(
489439
libc.src.fenv.fetestexcept
490440
libc.src.math.llroundl
491441
libc.src.__support.FPUtil.fp_bits
492-
# FIXME: Currently fails on the GPU build.
493-
UNIT_TEST_ONLY
494442
)
495443

496444
add_fp_unittest(
@@ -718,8 +666,6 @@ add_fp_unittest(
718666
libc.include.math
719667
libc.src.math.copysign
720668
libc.src.__support.FPUtil.fp_bits
721-
# FIXME: Currently fails on the GPU build.
722-
UNIT_TEST_ONLY
723669
)
724670

725671
add_fp_unittest(
@@ -734,8 +680,6 @@ add_fp_unittest(
734680
libc.include.math
735681
libc.src.math.copysignf
736682
libc.src.__support.FPUtil.fp_bits
737-
# FIXME: Currently fails on the GPU build.
738-
UNIT_TEST_ONLY
739683
)
740684

741685
add_fp_unittest(
@@ -750,8 +694,6 @@ add_fp_unittest(
750694
libc.include.math
751695
libc.src.math.copysignl
752696
libc.src.__support.FPUtil.fp_bits
753-
# FIXME: Currently fails on the GPU build.
754-
UNIT_TEST_ONLY
755697
)
756698

757699
add_fp_unittest(
@@ -766,8 +708,6 @@ add_fp_unittest(
766708
libc.include.math
767709
libc.src.math.copysignf128
768710
libc.src.__support.FPUtil.fp_bits
769-
# FIXME: Currently fails on the GPU build.
770-
UNIT_TEST_ONLY
771711
)
772712

773713
add_fp_unittest(
@@ -1189,8 +1129,6 @@ add_fp_unittest(
11891129
libc.include.math
11901130
libc.src.math.sqrtf
11911131
libc.src.__support.FPUtil.fp_bits
1192-
# FIXME: Currently fails on the GPU build.
1193-
UNIT_TEST_ONLY
11941132
)
11951133

11961134
add_fp_unittest(
@@ -1203,8 +1141,6 @@ add_fp_unittest(
12031141
libc.include.math
12041142
libc.src.math.sqrt
12051143
libc.src.__support.FPUtil.fp_bits
1206-
# FIXME: Currently fails on the GPU build.
1207-
UNIT_TEST_ONLY
12081144
)
12091145

12101146
add_fp_unittest(
@@ -1217,8 +1153,6 @@ add_fp_unittest(
12171153
libc.include.math
12181154
libc.src.math.sqrtl
12191155
libc.src.__support.FPUtil.fp_bits
1220-
# FIXME: Currently fails on the GPU build.
1221-
UNIT_TEST_ONLY
12221156
)
12231157

12241158
add_fp_unittest(
@@ -1231,8 +1165,6 @@ add_fp_unittest(
12311165
libc.include.math
12321166
libc.src.math.sqrtf128
12331167
libc.src.__support.FPUtil.fp_bits
1234-
# FIXME: Currently fails on the GPU build.
1235-
UNIT_TEST_ONLY
12361168
)
12371169

12381170
add_fp_unittest(
@@ -1247,8 +1179,6 @@ add_fp_unittest(
12471179
libc.src.__support.FPUtil.generic.sqrt
12481180
COMPILE_OPTIONS
12491181
-O3
1250-
# FIXME: Currently fails on the GPU build.
1251-
UNIT_TEST_ONLY
12521182
)
12531183

12541184
add_fp_unittest(
@@ -1263,8 +1193,6 @@ add_fp_unittest(
12631193
libc.src.__support.FPUtil.generic.sqrt
12641194
COMPILE_OPTIONS
12651195
-O3
1266-
# FIXME: Currently fails on the GPU build.
1267-
UNIT_TEST_ONLY
12681196
)
12691197

12701198
add_fp_unittest(
@@ -1279,8 +1207,6 @@ add_fp_unittest(
12791207
libc.src.__support.FPUtil.generic.sqrt
12801208
COMPILE_OPTIONS
12811209
-O3
1282-
# FIXME: Currently fails on the GPU build.
1283-
UNIT_TEST_ONLY
12841210
)
12851211

12861212
add_fp_unittest(
@@ -1295,8 +1221,6 @@ add_fp_unittest(
12951221
libc.src.__support.FPUtil.generic.sqrt
12961222
COMPILE_OPTIONS
12971223
-O3
1298-
# FIXME: Currently fails on the GPU build.
1299-
UNIT_TEST_ONLY
13001224
)
13011225

13021226
add_fp_unittest(

0 commit comments

Comments
 (0)