[libc] Re-enable several GPU math smoke tests #83147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: These were originally disabled after some changes caused them to regress. It seems that whatever broke them the first time a few months ago has been fixed elsewhere and they now work again. Re-enable all the ones that work. There are still a few that we need to look into, but this is a good start.
jhuber6
requested review from
Artem-B,
jplehr,
lntue,
michaelrj-google and
SchrodingerZhu
|
@llvm/pr-subscribers-libc Author: Joseph Huber (jhuber6) ChangesSummary: Full diff: https://github.com/llvm/llvm-project/pull/83147.diff 1 Files Affected:
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 0d6b33bd7d66e1..8ccb54f2926bb2 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -65,8 +65,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.fabs
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -81,14 +79,10 @@ add_fp_unittest(
libc.include.math
libc.src.math.fabsf
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
fabsl_test
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
SUITE
libc-math-smoke-tests
SRCS
@@ -103,8 +97,6 @@ add_fp_unittest(
add_fp_unittest(
fabsf128_test
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
SUITE
libc-math-smoke-tests
SRCS
@@ -129,8 +121,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.trunc
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -145,8 +135,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.truncf
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -161,8 +149,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.truncl
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -177,8 +163,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.truncf128
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -193,8 +177,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.ceil
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -209,8 +191,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.ceilf
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -225,8 +205,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.ceill
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -241,8 +219,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.ceilf128
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -257,8 +233,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.floor
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -273,8 +247,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.floorf
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -289,8 +261,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.floorl
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -305,8 +275,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.floorf128
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -321,8 +289,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.round
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -337,8 +303,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.roundf
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -353,8 +317,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.roundl
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -369,8 +331,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.roundf128
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -389,8 +349,6 @@ add_fp_unittest(
libc.src.fenv.fetestexcept
libc.src.math.lround
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -409,8 +367,6 @@ add_fp_unittest(
libc.src.fenv.fetestexcept
libc.src.math.lroundf
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -429,8 +385,6 @@ add_fp_unittest(
libc.src.fenv.fetestexcept
libc.src.math.lroundl
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -449,8 +403,6 @@ add_fp_unittest(
libc.src.fenv.fetestexcept
libc.src.math.llround
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -469,8 +421,6 @@ add_fp_unittest(
libc.src.fenv.fetestexcept
libc.src.math.llroundf
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -489,8 +439,6 @@ add_fp_unittest(
libc.src.fenv.fetestexcept
libc.src.math.llroundl
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -718,8 +666,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.copysign
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -734,8 +680,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.copysignf
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -750,8 +694,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.copysignl
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -766,8 +708,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.copysignf128
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1189,8 +1129,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.sqrtf
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1203,8 +1141,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.sqrt
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1217,8 +1153,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.sqrtl
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1231,8 +1165,6 @@ add_fp_unittest(
libc.include.math
libc.src.math.sqrtf128
libc.src.__support.FPUtil.fp_bits
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1247,8 +1179,6 @@ add_fp_unittest(
libc.src.__support.FPUtil.generic.sqrt
COMPILE_OPTIONS
-O3
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1263,8 +1193,6 @@ add_fp_unittest(
libc.src.__support.FPUtil.generic.sqrt
COMPILE_OPTIONS
-O3
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1279,8 +1207,6 @@ add_fp_unittest(
libc.src.__support.FPUtil.generic.sqrt
COMPILE_OPTIONS
-O3
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1295,8 +1221,6 @@ add_fp_unittest(
libc.src.__support.FPUtil.generic.sqrt
COMPILE_OPTIONS
-O3
- # FIXME: Currently fails on the GPU build.
- UNIT_TEST_ONLY
)
add_fp_unittest(
|
nickdesaulniers
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These were originally disabled after some changes caused them to
regress. It seems that whatever broke them the first time a few months
ago has been fixed elsewhere and they now work again. Re-enable all the
ones that work. There are still a few that we need to look into, but
this is a good start.