[clang][dataflow] Eliminate deprecated ControlFlowContext::build() overload.

Reviewed By: ymandel, xazax.hun

Differential Revision: https://reviews.llvm.org/D159262

Author: martinboehme

clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h

@@ -40,12 +40,6 @@ class ControlFlowContext {
   static llvm::Expected<ControlFlowContext> build(const Decl &D, Stmt &S,
                                                   ASTContext &C);
 
-  /// Builds a ControlFlowContext from an AST node. `D` is the function in which
-  /// `S` resides. `D` must not be null and `D->isTemplated()` must be false.
-  LLVM_DEPRECATED("Use the version that takes a const Decl & instead", "")
-  static llvm::Expected<ControlFlowContext> build(const Decl *D, Stmt &S,
-                                                  ASTContext &C);
-
   /// Returns the `Decl` containing the statement used to construct the CFG, if
   /// available.
   const Decl &getDecl() const { return ContainingDecl; }

clang/lib/Analysis/FlowSensitive/ControlFlowContext.cpp

@@ -109,15 +109,5 @@ ControlFlowContext::build(const Decl &D, Stmt &S, ASTContext &C) {
                             std::move(BlockReachable));
 }
 
-llvm::Expected<ControlFlowContext>
-ControlFlowContext::build(const Decl *D, Stmt &S, ASTContext &C) {
-  if (D == nullptr)
-    return llvm::createStringError(
-        std::make_error_code(std::errc::invalid_argument),
-        "Declaration must not be null");
-
-  return build(*D, S, C);
-}
-
 } // namespace dataflow
 } // namespace clang