Skip to content

Commit cd6e959

Browse files
Revert "[MC] Explicitly mark MCSymbol for MO_ExternalSymbol" (#133291)
Reverts #108880 . The patch has no regression test, no description of why the fix is necessary, and the code is modifying MC datastructures in a way that's forbidden in the AsmPrinter. Fixes #132055.
1 parent 75ca080 commit cd6e959

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

llvm/lib/Target/X86/X86MCInstLower.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -349,12 +349,8 @@ MCOperand X86MCInstLower::LowerMachineOperand(const MachineInstr *MI,
349349
return MCOperand::createImm(MO.getImm());
350350
case MachineOperand::MO_MachineBasicBlock:
351351
case MachineOperand::MO_GlobalAddress:
352+
case MachineOperand::MO_ExternalSymbol:
352353
return LowerSymbolOperand(MO, GetSymbolFromOperand(MO));
353-
case MachineOperand::MO_ExternalSymbol: {
354-
MCSymbol *Sym = GetSymbolFromOperand(MO);
355-
Sym->setExternal(true);
356-
return LowerSymbolOperand(MO, Sym);
357-
}
358354
case MachineOperand::MO_MCSymbol:
359355
return LowerSymbolOperand(MO, MO.getMCSymbol());
360356
case MachineOperand::MO_JumpTableIndex:

0 commit comments

Comments
 (0)