[MC] Explicitly mark MCSymbol for MO_ExternalSymbol #108880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lld-macho @llvm/pr-subscribers-backend-x86 Author: weiwei chen (weiweichen) Changes
Full diff: https://github.com/llvm/llvm-project/pull/108880.diff 1 Files Affected:
diff --git a/llvm/lib/Target/X86/X86MCInstLower.cpp b/llvm/lib/Target/X86/X86MCInstLower.cpp
index 77ddd2366e629e..949711f35aa584 100644
--- a/llvm/lib/Target/X86/X86MCInstLower.cpp
+++ b/llvm/lib/Target/X86/X86MCInstLower.cpp
@@ -350,8 +350,11 @@ MCOperand X86MCInstLower::LowerMachineOperand(const MachineInstr *MI,
return MCOperand::createImm(MO.getImm());
case MachineOperand::MO_MachineBasicBlock:
case MachineOperand::MO_GlobalAddress:
- case MachineOperand::MO_ExternalSymbol:
- return LowerSymbolOperand(MO, GetSymbolFromOperand(MO));
+ case MachineOperand::MO_ExternalSymbol: {
+ MCSymbol *Sym = GetSymbolFromOperand(MO);
+ Sym->setExternal(true);
+ return LowerSymbolOperand(MO, Sym);
+ }
case MachineOperand::MO_MCSymbol:
return LowerSymbolOperand(MO, MO.getMCSymbol());
case MachineOperand::MO_JumpTableIndex:
|
…eic/mark-x86-externalsymbol-mcsymbol-external
…eic/mark-x86-externalsymbol-mcsymbol-external
…eic/mark-x86-externalsymbol-mcsymbol-external
Mogball
reviewed
Sep 17, 2024
| @@ -350,8 +350,11 @@ MCOperand X86MCInstLower::LowerMachineOperand(const MachineInstr *MI, | |||
| return MCOperand::createImm(MO.getImm()); | |||
| case MachineOperand::MO_MachineBasicBlock: | |||
| case MachineOperand::MO_GlobalAddress: | |||
| case MachineOperand::MO_ExternalSymbol: | |||
| return LowerSymbolOperand(MO, GetSymbolFromOperand(MO)); | |||
| case MachineOperand::MO_ExternalSymbol: { | |||
There was a problem hiding this comment.
did you mean for MO_GlobalAddress and MO_MachineBasicBlock to also hit this branch?
There was a problem hiding this comment.
welp, no, 🤦♀️, thanks for pointing this out!
…eic/mark-x86-externalsymbol-mcsymbol-external
…eic/mark-x86-externalsymbol-mcsymbol-external
Mogball
approved these changes
Sep 20, 2024
|
Wouldn't this change require a test? |
Zentrik
added a commit
to Zentrik/llvm-project
that referenced
this pull request
Mar 21, 2025
)" This reverts commit 3d0846b.
efriedma-quic
added a commit
that referenced
this pull request
Mar 27, 2025
This reverts commit 3d0846b.
efriedma-quic
added a commit
that referenced
this pull request
Mar 28, 2025
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 28, 2025
…l" (#133291) Reverts llvm/llvm-project#108880 . The patch has no regression test, no description of why the fix is necessary, and the code is modifying MC datastructures in a way that's forbidden in the AsmPrinter. Fixes #132055.
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Mar 29, 2025
…3291) Reverts llvm#108880 . The patch has no regression test, no description of why the fix is necessary, and the code is modifying MC datastructures in a way that's forbidden in the AsmPrinter. Fixes llvm#132055. (cherry picked from commit cd6e959)
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
May 15, 2025
…l" (#133291) Reverts llvm/llvm-project#108880 . The patch has no regression test, no description of why the fix is necessary, and the code is modifying MC datastructures in a way that's forbidden in the AsmPrinter. Fixes #132055. (cherry picked from commit cd6e959)
oneseer
pushed a commit
to oneseer/llvm
that referenced
this pull request
May 24, 2025
Reverts llvm/llvm-project#108880 . The patch has no regression test, no description of why the fix is necessary, and the code is modifying MC datastructures in a way that's forbidden in the AsmPrinter. Fixes #132055. patch.cherry: true patch.metadata.original_sha: cd6e959 patch.platforms: chromiumos patch.version_range.from: 550362 patch.version_range.until: 570122 Change-Id: I998708a3260843e5c306edc18251835d2e2d5ce3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCSymbolforMO_ExternalSymbolto be external when created.