Skip to content

Commit d6219e6

Browse files
[libc] Make fstatvfs test less flakey (#115949)
1 parent 84e95be commit d6219e6

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

libc/test/src/sys/statvfs/linux/fstatvfs_test.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,13 @@ TEST(LlvmLibcSysFStatvfsTest, FStatvfsBasic) {
3333
TEST(LlvmLibcSysFStatvfsTest, FStatvfsInvalidPath) {
3434
struct statvfs buf;
3535

36-
constexpr const char *FILENAME = "statvfs.testdir";
36+
constexpr const char *FILENAME = "fstatvfs.testdir";
3737
auto TEST_DIR = libc_make_test_file_path(FILENAME);
3838

39+
// Always delete the folder so that we start in a consistent state.
40+
LIBC_NAMESPACE::rmdir(TEST_DIR);
41+
LIBC_NAMESPACE::libc_errno = 0; // Reset errno
42+
3943
ASSERT_THAT(LIBC_NAMESPACE::mkdirat(AT_FDCWD, TEST_DIR, S_IRWXU),
4044
Succeeds(0));
4145

libc/test/src/sys/statvfs/linux/statvfs_test.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ TEST(LlvmLibcSysStatvfsTest, StatvfsInvalidPath) {
3333
constexpr const char *FILENAME = "statvfs.testdir";
3434
auto TEST_DIR = libc_make_test_file_path(FILENAME);
3535

36+
// Always delete the folder so that we start in a consistent state.
37+
LIBC_NAMESPACE::rmdir(TEST_DIR);
38+
LIBC_NAMESPACE::libc_errno = 0; // Reset errno
39+
3640
ASSERT_THAT(LIBC_NAMESPACE::mkdirat(AT_FDCWD, TEST_DIR, S_IRWXU),
3741
Succeeds(0));
3842

0 commit comments

Comments
 (0)