Skip to content

Commit dab4121

Browse files
authored
[PowerPC] Add custom lowering for ssubo (#111748) (#115875)
This patch is to improve the codegen for ssubo node for i32 by custom lowering.
1 parent a4c8ef0 commit dab4121

File tree

4 files changed

+40
-13
lines changed

4 files changed

+40
-13
lines changed

llvm/lib/Target/PowerPC/PPCISelLowering.cpp

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,11 @@ PPCTargetLowering::PPCTargetLowering(const PPCTargetMachine &TM,
198198

199199
setOperationAction(ISD::UADDO, RegVT, Custom);
200200

201+
// On P10, the default lowering generates better code using the
202+
// setbc instruction.
203+
if (!Subtarget.hasP10Vector())
204+
setOperationAction(ISD::SSUBO, MVT::i32, Custom);
205+
201206
// Match BITREVERSE to customized fast code sequence in the td file.
202207
setOperationAction(ISD::BITREVERSE, MVT::i32, Legal);
203208
setOperationAction(ISD::BITREVERSE, MVT::i64, Legal);
@@ -12041,6 +12046,27 @@ SDValue PPCTargetLowering::LowerUaddo(SDValue Op, SelectionDAG &DAG) const {
1204112046
return Res;
1204212047
}
1204312048

12049+
SDValue PPCTargetLowering::LowerSSUBO(SDValue Op, SelectionDAG &DAG) const {
12050+
12051+
SDLoc dl(Op);
12052+
SDValue LHS = Op.getOperand(0);
12053+
SDValue RHS = Op.getOperand(1);
12054+
12055+
SDValue Sub = DAG.getNode(ISD::SUB, dl, MVT::i32, LHS, RHS);
12056+
12057+
SDValue Xor1 = DAG.getNode(ISD::XOR, dl, MVT::i32, RHS, LHS);
12058+
SDValue Xor2 = DAG.getNode(ISD::XOR, dl, MVT::i32, Sub, LHS);
12059+
12060+
SDValue And = DAG.getNode(ISD::AND, dl, MVT::i32, Xor1, Xor2);
12061+
12062+
SDValue Overflow = DAG.getNode(ISD::SRL, dl, MVT::i32, And,
12063+
DAG.getConstant(31, dl, MVT::i32));
12064+
SDValue OverflowTrunc =
12065+
DAG.getNode(ISD::TRUNCATE, dl, Op.getNode()->getValueType(1), Overflow);
12066+
12067+
return DAG.getMergeValues({Sub, OverflowTrunc}, dl);
12068+
}
12069+
1204412070
/// LowerOperation - Provide custom lowering hooks for some operations.
1204512071
///
1204612072
SDValue PPCTargetLowering::LowerOperation(SDValue Op, SelectionDAG &DAG) const {
@@ -12063,6 +12089,8 @@ SDValue PPCTargetLowering::LowerOperation(SDValue Op, SelectionDAG &DAG) const {
1206312089
case ISD::SETCC: return LowerSETCC(Op, DAG);
1206412090
case ISD::INIT_TRAMPOLINE: return LowerINIT_TRAMPOLINE(Op, DAG);
1206512091
case ISD::ADJUST_TRAMPOLINE: return LowerADJUST_TRAMPOLINE(Op, DAG);
12092+
case ISD::SSUBO:
12093+
return LowerSSUBO(Op, DAG);
1206612094

1206712095
case ISD::INLINEASM:
1206812096
case ISD::INLINEASM_BR: return LowerINLINEASM(Op, DAG);

llvm/lib/Target/PowerPC/PPCISelLowering.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,6 +1285,7 @@ namespace llvm {
12851285
SDValue LowerJumpTable(SDValue Op, SelectionDAG &DAG) const;
12861286
SDValue LowerUaddo(SDValue Op, SelectionDAG &DAG) const;
12871287
SDValue LowerSETCC(SDValue Op, SelectionDAG &DAG) const;
1288+
SDValue LowerSSUBO(SDValue Op, SelectionDAG &DAG) const;
12881289
SDValue LowerINIT_TRAMPOLINE(SDValue Op, SelectionDAG &DAG) const;
12891290
SDValue LowerADJUST_TRAMPOLINE(SDValue Op, SelectionDAG &DAG) const;
12901291
SDValue LowerINLINEASM(SDValue Op, SelectionDAG &DAG) const;

llvm/test/CodeGen/PowerPC/saddo-ssubo.ll

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -129,12 +129,11 @@ entry:
129129
define i1 @test_ssubo_i32(i32 %a, i32 %b) nounwind {
130130
; CHECK-LABEL: test_ssubo_i32:
131131
; CHECK: # %bb.0: # %entry
132-
; CHECK-NEXT: sub 5, 3, 4
133-
; CHECK-NEXT: cmpwi 1, 4, 0
134-
; CHECK-NEXT: cmpw 5, 3
135-
; CHECK-NEXT: li 3, 1
136-
; CHECK-NEXT: creqv 20, 5, 0
137-
; CHECK-NEXT: isel 3, 0, 3, 20
132+
; CHECK-NEXT: xor 5, 4, 3
133+
; CHECK-NEXT: sub 4, 3, 4
134+
; CHECK-NEXT: xor 3, 4, 3
135+
; CHECK-NEXT: and 3, 5, 3
136+
; CHECK-NEXT: srwi 3, 3, 31
138137
; CHECK-NEXT: blr
139138
entry:
140139
%res = call { i32, i1 } @llvm.ssub.with.overflow.i32(i32 %a, i32 %b) nounwind

llvm/test/CodeGen/PowerPC/ssubo-32.ll

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,12 @@
66
define i1 @subovfi_i32(i32 noundef %a, i32 noundef %b, ptr %c) {
77
; CHECK-LABEL: subovfi_i32:
88
; CHECK: # %bb.0: # %entry
9-
; CHECK-NEXT: sub 6, 3, 4
10-
; CHECK-NEXT: cmpwi 1, 4, 0
11-
; CHECK-NEXT: cmpw 6, 3
12-
; CHECK-NEXT: li 3, 1
13-
; CHECK-NEXT: stw 6, 0(5)
14-
; CHECK-NEXT: creqv 20, 5, 0
15-
; CHECK-NEXT: isel 3, 0, 3, 20
9+
; CHECK-NEXT: xor 6, 4, 3
10+
; CHECK-NEXT: sub 4, 3, 4
11+
; CHECK-NEXT: xor 3, 4, 3
12+
; CHECK-NEXT: stw 4, 0(5)
13+
; CHECK-NEXT: and 3, 6, 3
14+
; CHECK-NEXT: srwi 3, 3, 31
1615
; CHECK-NEXT: blr
1716
entry:
1817
%0 = call { i32, i1 } @llvm.ssub.with.overflow.i32(i32 %a, i32 %b)

0 commit comments

Comments
 (0)