Skip to content

Commit dc6ce60

Browse files
authored
[mlir][gpu] Remove offloadingHandler from ModuleToBinary (#90368)
This patch removes the `offloadingHandler` option from the `ModuleToBinary` pass. The option is removed as it cannot be parsed from textual form. This fixes issue #90344.
1 parent b6a8f54 commit dc6ce60

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

mlir/include/mlir/Dialect/GPU/Transforms/Passes.td

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ def GpuModuleToBinaryPass
8888
4. `fatbinary`, `fatbin`: produces fatbinaries.
8989
}];
9090
let options = [
91-
Option<"offloadingHandler", "handler", "Attribute", "nullptr",
92-
"Offloading handler to be attached to the resulting binary op.">,
9391
Option<"toolkitPath", "toolkit", "std::string", [{""}],
9492
"Toolkit path.">,
9593
ListOption<"linkFiles", "l", "std::string",

mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,7 @@ void GpuModuleToBinaryPass::runOnOperation() {
8888
TargetOptions targetOptions(toolkitPath, linkFiles, cmdOptions, *targetFormat,
8989
lazyTableBuilder);
9090
if (failed(transformGpuModulesToBinaries(
91-
getOperation(),
92-
offloadingHandler ? dyn_cast<OffloadingLLVMTranslationAttrInterface>(
93-
offloadingHandler.getValue())
94-
: OffloadingLLVMTranslationAttrInterface(nullptr),
91+
getOperation(), OffloadingLLVMTranslationAttrInterface(nullptr),
9592
targetOptions)))
9693
return signalPassFailure();
9794
}

0 commit comments

Comments
 (0)