[mlir][gpu] Remove offloadingHandler from ModuleToBinary

[fabianmcg]

This patch removes the offloadingHandler option from the ModuleToBinary pass. The option is removed as it cannot be parsed from textual form.

This fixes issue #90344.

[llvmbot]

@llvm/pr-subscribers-mlir-gpu

@llvm/pr-subscribers-mlir

Author: Fabian Mora (fabianmcg)

Changes

This patch removes the offloadingHandler option from the ModuleToBinary pass. The option is removed as it cannot be parsed from textual form.

This fixes issue #90344.

---

Full diff: https://github.com/llvm/llvm-project/pull/90368.diff

2 Files Affected:

• (modified) mlir/include/mlir/Dialect/GPU/Transforms/Passes.td (-2)
• (modified) mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp (+1-4)

diff --git a/mlir/include/mlir/Dialect/GPU/Transforms/Passes.td b/mlir/include/mlir/Dialect/GPU/Transforms/Passes.td
index a8235bed6f2764..4a9ddafdd177d2 100644
--- a/mlir/include/mlir/Dialect/GPU/Transforms/Passes.td
+++ b/mlir/include/mlir/Dialect/GPU/Transforms/Passes.td
@@ -88,8 +88,6 @@ def GpuModuleToBinaryPass
     4. `fatbinary`, `fatbin`: produces fatbinaries.
   }];
   let options = [
-    Option<"offloadingHandler", "handler", "Attribute", "nullptr",
-           "Offloading handler to be attached to the resulting binary op.">,
     Option<"toolkitPath", "toolkit", "std::string", [{""}],
            "Toolkit path.">,
     ListOption<"linkFiles", "l", "std::string",
diff --git a/mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp b/mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp
index 01613ab5268bc4..836e939a8295ba 100644
--- a/mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp
+++ b/mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp
@@ -88,10 +88,7 @@ void GpuModuleToBinaryPass::runOnOperation() {
   TargetOptions targetOptions(toolkitPath, linkFiles, cmdOptions, *targetFormat,
                               lazyTableBuilder);
   if (failed(transformGpuModulesToBinaries(
-          getOperation(),
-          offloadingHandler ? dyn_cast<OffloadingLLVMTranslationAttrInterface>(
-                                  offloadingHandler.getValue())
-                            : OffloadingLLVMTranslationAttrInterface(nullptr),
+          getOperation(), OffloadingLLVMTranslationAttrInterface(nullptr),
           targetOptions)))
     return signalPassFailure();
 }

[fabianmcg]

I opted for removing the option for now.
The alternative of adding an option parser for an mlir::Attribute doesn't work, as parsing an attribute requires a valid MLIRContext and there's no safe way to pass the context to the option parser.