Skip to content

Commit dc78e8a

Browse files
committed
[Review] Turn builtin input from unsigned to signed
1 parent 41af387 commit dc78e8a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

clang/include/clang/Basic/BuiltinsAMDGPU.def

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ BUILTIN(__builtin_amdgcn_cvt_pknorm_u16, "E2Usff", "nc")
140140
BUILTIN(__builtin_amdgcn_cvt_pk_i16, "E2sii", "nc")
141141
BUILTIN(__builtin_amdgcn_cvt_pk_u16, "E2UsUiUi", "nc")
142142
BUILTIN(__builtin_amdgcn_cvt_pk_u8_f32, "UifUiUi", "nc")
143-
BUILTIN(__builtin_amdgcn_cvt_off_f32_i4, "fUi", "nc")
143+
BUILTIN(__builtin_amdgcn_cvt_off_f32_i4, "fi", "nc")
144144
BUILTIN(__builtin_amdgcn_sad_u8, "UiUiUiUi", "nc")
145145
BUILTIN(__builtin_amdgcn_msad_u8, "UiUiUiUi", "nc")
146146
BUILTIN(__builtin_amdgcn_sad_hi_u8, "UiUiUiUi", "nc")
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
// RUN: %clang_cc1 -triple amdgcn-- -verify -S -o - %s
22

3-
void test_builtin_amdgcn_cvt_off_f32_i4(unsigned n) {
3+
void test_builtin_amdgcn_cvt_off_f32_i4(int n) {
44
struct A{ unsigned x; } a;
55
__builtin_amdgcn_cvt_off_f32_i4(n, n); // expected-error {{too many arguments to function call, expected 1, have 2}}
66
__builtin_amdgcn_cvt_off_f32_i4(); // expected-error {{too few arguments to function call, expected 1, have 0}}
7-
__builtin_amdgcn_cvt_off_f32_i4(a); // expected-error {{passing '__private struct A' to parameter of incompatible type 'unsigned int'}}
7+
__builtin_amdgcn_cvt_off_f32_i4(a); // expected-error {{passing '__private struct A' to parameter of incompatible type 'int'}}
88
}

0 commit comments

Comments
 (0)