Skip to content

Commit e0223fa

Browse files
authored
[Clang][NFC] Rename SecondArgIsLastNamedArgument for clarity and consistency (#131346)
Change the name of the control variable `SecondArgIsLastNamedArgument` to `SecondArgIsLastNonVariadicArgument` for clarity and consistency. Following feedback on earlier PR that was merged: - #131238 (comment)
1 parent 6085f3f commit e0223fa

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

clang/lib/Sema/SemaChecking.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4898,15 +4898,15 @@ bool Sema::BuiltinVAStart(unsigned BuiltinID, CallExpr *TheCall) {
48984898
return false;
48994899
}
49004900

4901-
// These are valid if SecondArgIsLastNamedArgument is false after the next
4902-
// block.
4901+
// These are valid if SecondArgIsLastNonVariadicArgument is false after the
4902+
// next block.
49034903
QualType Type;
49044904
SourceLocation ParamLoc;
49054905
bool IsCRegister = false;
4906-
bool SecondArgIsLastNamedArgument = false;
4906+
bool SecondArgIsLastNonVariadicArgument = false;
49074907
if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
49084908
if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
4909-
SecondArgIsLastNamedArgument = PV == LastParam;
4909+
SecondArgIsLastNonVariadicArgument = PV == LastParam;
49104910

49114911
Type = PV->getType();
49124912
ParamLoc = PV->getLocation();
@@ -4915,7 +4915,7 @@ bool Sema::BuiltinVAStart(unsigned BuiltinID, CallExpr *TheCall) {
49154915
}
49164916
}
49174917

4918-
if (!SecondArgIsLastNamedArgument)
4918+
if (!SecondArgIsLastNonVariadicArgument)
49194919
Diag(TheCall->getArg(1)->getBeginLoc(),
49204920
diag::warn_second_arg_of_va_start_not_last_non_variadic_param);
49214921
else if (IsCRegister || Type->isReferenceType() ||

0 commit comments

Comments
 (0)