[Clang][NFC] Rename SecondArgIsLastNamedArgument for clarity and consistency

[imdj]

Change the name of the control variable SecondArgIsLastNamedArgument to SecondArgIsLastNonVariadicArgument for clarity and consistency.

Following feedback on earlier PR that was merged:

• [clang] Fix inaccurate wording of warn_second_arg_of_va_start_not_last_named_param #131238 (comment)_

[llvmbot]

@llvm/pr-subscribers-clang

Author: Imad Aldij (imdj)

Changes

Change the name of the control variable SecondArgIsLastNamedArgument to SecondArgIsLastNonVariadicArgument for clarity and consistency.

Following feedback on earlier PR that was merged:

• #131238

---

Full diff: https://github.com/llvm/llvm-project/pull/131346.diff

1 Files Affected:

• (modified) clang/lib/Sema/SemaChecking.cpp (+4-4)

diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index e99e30d75df94..c8e8cb6f4c150 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -4867,14 +4867,14 @@ bool Sema::BuiltinVAStart(unsigned BuiltinID, CallExpr *TheCall) {
   // current function or method. In C23 mode, if the second argument is an
   // integer constant expression with value 0, then we don't bother with this
   // check.
-  bool SecondArgIsLastNamedArgument = false;
+  bool SecondArgIsLastNonVariadicArgument = false;
   const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
   if (std::optional<llvm::APSInt> Val =
           TheCall->getArg(1)->getIntegerConstantExpr(Context);
       Val && LangOpts.C23 && *Val == 0)
     return false;
 
-  // These are valid if SecondArgIsLastNamedArgument is false after the next
+  // These are valid if SecondArgIsLastNonVariadicArgument is false after the next
   // block.
   QualType Type;
   SourceLocation ParamLoc;
@@ -4882,7 +4882,7 @@ bool Sema::BuiltinVAStart(unsigned BuiltinID, CallExpr *TheCall) {
 
   if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
     if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
-      SecondArgIsLastNamedArgument = PV == LastParam;
+      SecondArgIsLastNonVariadicArgument = PV == LastParam;
 
       Type = PV->getType();
       ParamLoc = PV->getLocation();
@@ -4891,7 +4891,7 @@ bool Sema::BuiltinVAStart(unsigned BuiltinID, CallExpr *TheCall) {
     }
   }
 
-  if (!SecondArgIsLastNamedArgument)
+  if (!SecondArgIsLastNonVariadicArgument)
     Diag(TheCall->getArg(1)->getBeginLoc(),
          diag::warn_second_arg_of_va_start_not_last_non_variadic_param);
   else if (IsCRegister || Type->isReferenceType() ||

[github-actions]

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

[imdj]

cc: @erichkeane

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[erichkeane]

I'm in favor, but lets let @AaronBallman take a look/click merge if is OK too.

[imdj]

I just did a rebase after the merge of #131166 .
Could you take a look please @AaronBallman and see if everything looks good now?

[AaronBallman]

LGTM