Skip to content

Commit e527041

Browse files
committed
add test, remove fixme comment
1 parent 9df037d commit e527041

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

clang/lib/Driver/ToolChains/HLSL.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -279,9 +279,6 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args, StringRef BoundArch,
279279
DAL->AddJoinedArg(nullptr, Opts.getOption(options::OPT_O), "3");
280280
}
281281

282-
// FIXME: add validation for enable_16bit_types should be after HLSL 2018 and
283-
// shader model 6.2.
284-
// See: https://github.com/llvm/llvm-project/issues/57876
285282
if (DAL->hasArg(options::OPT_fnative_half_type)) {
286283

287284
bool HVArgIsValid = true;

clang/test/Options/enable_16bit_types_validation.hlsl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
// both_invalid: error: enable_16bit_types option only valid when target shader model [-T] is >= 6.2 and HLSL Version [-HV] is >= 2021
88
// HV_invalid: error: enable_16bit_types option only valid when target shader model [-T] is >= 6.2 and HLSL Version [-HV] is >= 2021
99
// TP_invalid: error: enable_16bit_types option only valid when target shader model [-T] is >= 6.2 and HLSL Version [-HV] is >= 2021
10+
1011
// valid: "dxil-unknown-shadermodel6.4-library"
1112
// valid-SAME: "-std=hlsl2021"
1213
// valid-SAME: "-fnative-half-type"

0 commit comments

Comments
 (0)