[mojo-lang] Use Lower Case in TailCallAttribute Member Names (#98253)

stumpOS · web-flow · commit e5aa7999bf1b · 2024-07-09T17:20:32.000-07:00
The build is broken with the error message:
```
error: declaration of 'mlir::LLVM::tailcallkind::TailCallKind mlir::LLVM::detail::TailCallKindAttrStorage::TailCallKind' changes meaning of 'TailCallKind'
```
I cannot replicate the error locally because I think it's only reported
by GCC not clang. However, I think the change in this patch may fix it.
diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
@@ -1082,8 +1082,8 @@ def LLVM_ZeroAttr : LLVM_Attr<"Zero", "zero">;
 //===----------------------------------------------------------------------===//
 
 def TailCallKindAttr : LLVM_Attr<"TailCallKind", "tailcallkind"> {
-  let parameters = (ins "TailCallKind":$TailCallKind);
-  let assemblyFormat = "`<` $TailCallKind `>`";
+  let parameters = (ins "TailCallKind":$tailCallKind);
+  let assemblyFormat = "`<` $tailCallKind `>`";
 }
 
 #endif // LLVMIR_ATTRDEFS

Original file line number	Diff line number	Diff line change
`@@ -1082,8 +1082,8 @@ def LLVM_ZeroAttr : LLVM_Attr<"Zero", "zero">;`
`1082`	`1082`	`//===----------------------------------------------------------------------===//`
`1083`	`1083`
`1084`	`1084`	`def TailCallKindAttr : LLVM_Attr<"TailCallKind", "tailcallkind"> {`
`1085`		`- let parameters = (ins "TailCallKind":$TailCallKind);`
`1086`		- let assemblyFormat = "`<` $TailCallKind `>`";
	`1085`	`+ let parameters = (ins "TailCallKind":$tailCallKind);`
	`1086`	+ let assemblyFormat = "`<` $tailCallKind `>`";
`1087`	`1087`	`}`
`1088`	`1088`
`1089`	`1089`	`#endif // LLVMIR_ATTRDEFS`