[mojo-lang] Use Lower Case in TailCallAttribute Member Names #98253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-llvm @llvm/pr-subscribers-mlir Author: Steffi Stumpos (stumpOS) ChangesThe build is broken with the error message: I cannot replicate the error locally because I think it's only reported by GCC not clang. However, I think the change in this patch may fix it. Full diff: https://github.com/llvm/llvm-project/pull/98253.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
index 25a6ee27b01db..aefc02bce40fb 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
@@ -1082,8 +1082,8 @@ def LLVM_ZeroAttr : LLVM_Attr<"Zero", "zero">;
//===----------------------------------------------------------------------===//
def TailCallKindAttr : LLVM_Attr<"TailCallKind", "tailcallkind"> {
- let parameters = (ins "TailCallKind":$TailCallKind);
- let assemblyFormat = "`<` $TailCallKind `>`";
+ let parameters = (ins "TailCallKind":$tailCallKind);
+ let assemblyFormat = "`<` $tailCallKind `>`";
}
#endif // LLVMIR_ATTRDEFS
|
stumpOS
changed the title
aaryanshukla
pushed a commit
to aaryanshukla/llvm-project
that referenced
this pull request
Jul 14, 2024
) The build is broken with the error message: ``` error: declaration of 'mlir::LLVM::tailcallkind::TailCallKind mlir::LLVM::detail::TailCallKindAttrStorage::TailCallKind' changes meaning of 'TailCallKind' ``` I cannot replicate the error locally because I think it's only reported by GCC not clang. However, I think the change in this patch may fix it.
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Aug 13, 2024
…569369d18 Local branch amd-gfx 3a45693 Merged main:f35318e828d166bee04a117c1a87c1c0e32a57da into amd-gfx:0bb3d2db3b39 Remote branch main e5aa799 [mojo-lang] Use Lower Case in TailCallAttribute Member Names (llvm#98253)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build is broken with the error message:
I cannot replicate the error locally because I think it's only reported by GCC not clang. However, I think the change in this patch may fix it.