Skip to content

Commit e973f7a

Browse files
authored
[RISCV][Xqcicsr] Instructions have Side Effects (#118089)
Xqcicsr was added in #117169. I missed that `hasSideEffects` was set to 0, rather than 1 (which all other CSR-modifying instructions have). This has no effect on the current assembly-only support, but I think is worth fixing before I forget. I accidentally fixed the closing comment in 9300274.
1 parent 2b3266c commit e973f7a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

llvm/lib/Target/RISCV/RISCVInstrInfoXqci.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class QCIStore_ScaleIdx<bits<4> func4, string opcodestr>
5050
//===----------------------------------------------------------------------===//
5151

5252
let Predicates = [HasVendorXqcicsr, IsRV32], DecoderNamespace = "Xqcicsr" in {
53-
let hasSideEffects = 0, mayLoad = 0, mayStore = 0 in {
53+
let hasSideEffects = 1, mayLoad = 0, mayStore = 0 in {
5454
def QC_CSRRWR : RVInstR<0b1000110, 0b000, OPC_SYSTEM, (outs GPR:$rd),
5555
(ins GPR:$rs1, GPRNoX0:$rs2), "qc.csrrwr",
5656
"$rd, $rs1, $rs2">;

0 commit comments

Comments
 (0)