Revert "[clang] Silence GCC warnings about control reaching end of non void function"

fmayer · fmayer · commit f885e02cf7ca · 2024-09-13T15:01:27.000-07:00
This reverts commit 90a2e0b. Reverting parent CL Pull Request: #108646
diff --git a/clang/include/clang/Basic/DiagnosticIDs.h b/clang/include/clang/Basic/DiagnosticIDs.h
@@ -18,7 +18,6 @@
 #include "clang/Basic/LLVM.h"
 #include "llvm/ADT/IntrusiveRefCntPtr.h"
 #include "llvm/ADT/StringRef.h"
-#include "llvm/Support/ErrorHandling.h"
 #include <optional>
 #include <vector>
 
@@ -311,7 +310,6 @@ class DiagnosticIDs : public RefCountedBase<DiagnosticIDs> {
         return {diag::Severity::Fatal, std::string(Message), CLASS_ERROR,
                 /*ShowInSystemHeader*/ true};
       }
-      llvm_unreachable("Fully covered switch above!");
     }());
   }
 
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
@@ -7331,7 +7331,6 @@ static bool diagnoseDiagnoseIfAttrsWith(Sema &S, const NamedDecl *ND,
     case DiagnoseIfAttr::DS_error:
       return diag::Severity::Error;
     }
-    llvm_unreachable("Fully covered switch above!");
   };
 
   for (const auto *DIA : llvm::make_range(WarningBegin, Attrs.end()))

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`#include "clang/Basic/LLVM.h"`
`19`	`19`	`#include "llvm/ADT/IntrusiveRefCntPtr.h"`
`20`	`20`	`#include "llvm/ADT/StringRef.h"`
`21`		`-#include "llvm/Support/ErrorHandling.h"`
`22`	`21`	`#include <optional>`
`23`	`22`	`#include <vector>`
`24`	`23`
`@@ -311,7 +310,6 @@ class DiagnosticIDs : public RefCountedBase<DiagnosticIDs> {`
`311`	`310`	`return {diag::Severity::Fatal, std::string(Message), CLASS_ERROR,`
`312`	`311`	`/ShowInSystemHeader/ true};`
`313`	`312`	`}`
`314`		`- llvm_unreachable("Fully covered switch above!");`
`315`	`313`	`}());`
`316`	`314`	`}`
`317`	`315`
Original file line number	Diff line number	Diff line change
`@@ -7331,7 +7331,6 @@ static bool diagnoseDiagnoseIfAttrsWith(Sema &S, const NamedDecl *ND,`
`7331`	`7331`	`case DiagnoseIfAttr::DS_error:`
`7332`	`7332`	`return diag::Severity::Error;`
`7333`	`7333`	`}`
`7334`		`- llvm_unreachable("Fully covered switch above!");`
`7335`	`7334`	`};`
`7336`	`7335`
`7337`	`7336`	`for (const auto *DIA : llvm::make_range(WarningBegin, Attrs.end()))`