Skip to content

Commit fbcde15

Browse files
authored
[lldb-dap] Minor visual changes to the modules UI (#139328)
Small assortment of changes to the modules UI after trying it out: - Print the load address as hexadecimal. - Remove spurious space before colon. - Drop "Module" prefix from tooltip title. - Capitalize bold list items.
1 parent ce9a898 commit fbcde15

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,23 +25,25 @@ export class ModulesDataProvider
2525
}
2626

2727
const tooltip = new vscode.MarkdownString();
28-
tooltip.appendMarkdown(`# Module '${module.name}'\n\n`);
29-
tooltip.appendMarkdown(`- **id** : ${module.id}\n`);
28+
tooltip.appendMarkdown(`# ${module.name}\n\n`);
29+
tooltip.appendMarkdown(`- **ID**: ${module.id}\n`);
3030
if (module.addressRange) {
31-
tooltip.appendMarkdown(`- **load address** : ${module.addressRange}\n`);
31+
tooltip.appendMarkdown(
32+
`- **Load address**: 0x${Number(module.addressRange).toString(16)}\n`,
33+
);
3234
}
3335
if (module.path) {
34-
tooltip.appendMarkdown(`- **path** : ${module.path}\n`);
36+
tooltip.appendMarkdown(`- **Path**: ${module.path}\n`);
3537
}
3638
if (module.version) {
37-
tooltip.appendMarkdown(`- **version** : ${module.version}\n`);
39+
tooltip.appendMarkdown(`- **Version**: ${module.version}\n`);
3840
}
3941
if (module.symbolStatus) {
40-
tooltip.appendMarkdown(`- **symbol status** : ${module.symbolStatus}\n`);
42+
tooltip.appendMarkdown(`- **Symbol status**: ${module.symbolStatus}\n`);
4143
}
4244
if (module.symbolFilePath) {
4345
tooltip.appendMarkdown(
44-
`- **symbol file path** : ${module.symbolFilePath}\n`,
46+
`- **Symbol file path**: ${module.symbolFilePath}\n`,
4547
);
4648
}
4749

0 commit comments

Comments
 (0)