Skip to content

[lldb-dap] Minor visual changes to the modules UI #139328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

JDevlieghere
Copy link
Member

Small assortment of changes to the modules UI after trying it out:

  • Print the load address as hexadecimal.
  • Remove spurious space before colon.
  • Drop "Module" prefix from tooltip title.
  • Capitalize bold list items.
Screenshot 2025-05-09 at 2 34 10 PM

Small assortment of changes to the modules UI after trying it out:

 - Print the load address as hexadecimal.
 - Remove spurious space before colon.
 - Drop "Module" prefix from tooltip title.
 - Capitalize bold list items.
@llvmbot
Copy link
Member

llvmbot commented May 9, 2025

@llvm/pr-subscribers-lldb

Author: Jonas Devlieghere (JDevlieghere)

Changes

Small assortment of changes to the modules UI after trying it out:

  • Print the load address as hexadecimal.
  • Remove spurious space before colon.
  • Drop "Module" prefix from tooltip title.
  • Capitalize bold list items.

<img width="817" alt="Screenshot 2025-05-09 at 2 34 10 PM" src="https://github.com/user-attachments/assets/5f902dae-87f2-4716-92f4-27e9dd3f6b37" />


Full diff: https://github.com/llvm/llvm-project/pull/139328.diff

1 Files Affected:

  • (modified) lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts (+9-7)
diff --git a/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts b/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts
index 5af3d52e9870c..07b89b267b536 100644
--- a/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts
+++ b/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts
@@ -25,23 +25,25 @@ export class ModulesDataProvider
     }
 
     const tooltip = new vscode.MarkdownString();
-    tooltip.appendMarkdown(`# Module '${module.name}'\n\n`);
-    tooltip.appendMarkdown(`- **id** : ${module.id}\n`);
+    tooltip.appendMarkdown(`# ${module.name}\n\n`);
+    tooltip.appendMarkdown(`- **ID** : ${module.id}\n`);
     if (module.addressRange) {
-      tooltip.appendMarkdown(`- **load address** : ${module.addressRange}\n`);
+      tooltip.appendMarkdown(
+        `- **Load address**: 0x${Number(module.addressRange).toString(16)}\n`,
+      );
     }
     if (module.path) {
-      tooltip.appendMarkdown(`- **path** : ${module.path}\n`);
+      tooltip.appendMarkdown(`- **Path**: ${module.path}\n`);
     }
     if (module.version) {
-      tooltip.appendMarkdown(`- **version** : ${module.version}\n`);
+      tooltip.appendMarkdown(`- **Version**: ${module.version}\n`);
     }
     if (module.symbolStatus) {
-      tooltip.appendMarkdown(`- **symbol status** : ${module.symbolStatus}\n`);
+      tooltip.appendMarkdown(`- **Symbol status**: ${module.symbolStatus}\n`);
     }
     if (module.symbolFilePath) {
       tooltip.appendMarkdown(
-        `- **symbol file path** : ${module.symbolFilePath}\n`,
+        `- **Symbol file path**: ${module.symbolFilePath}\n`,
       );
     }
 

Copy link
Contributor

@ashgti ashgti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I didn't realize I could directly edit this, I thought I was doing a suggestion but clearly I need to learn the github pull request UI better...

@JDevlieghere JDevlieghere merged commit fbcde15 into llvm:main May 9, 2025
8 of 9 checks passed
@JDevlieghere JDevlieghere deleted the lldb-dap-module-ui branch May 9, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants