[clang-format] AlignConsecutiveMacros fights with Visual Studio and resource.h

[mydeveloperday]

Bugzilla Link	51412
Version	unspecified
OS	Windows NT

Extended Description

clang-format AlignConsecutiveMacros feature is excellent, but it causes real problems when using the resource editor in Visual Studio

A resource.h file will be "Align" with an alignment of 40

//{{NO_DEPENDENCIES}}
// Microsoft Visual C++ generated include file.
// Used by MyTest.rc
//
#define IDP_OLE_INIT_FAILED             100
#define IDP_FAILED_TO_CREATE            102
#define ID_STATUSBAR_SHOW               108
#define ID_STATUSBAR_TEXT               109

if it encounters a long symbol it will push it out

#define ID_VERYVERYVERYVERY_LONG_LONG_LONG_LONG_RESOURCE 33221

Every time we make a change in the resource editor in visual studio the resource.h will be written out (and its not auto clang-formatted)

If you check all files for "clang-formatting" then resource.h will fail everytime

It would be good to have some AlignConsecutiveMacros options so that clang-format didn't fight against this format

Some sort of "AlignConsecutiveMacrosMinMaxAlignment: 40"

[mydeveloperday]

This is accepted and ready to go https://reviews.llvm.org/D112019

Just trying to decide if I should allow this feature to be limited to only a set set of filenames (i.e. have some sort of regex to apply it only to specific files i.e. resource.h or all files *

[mkurdej]

Just trying to decide if I should allow this feature to be limited to only a set set of filenames (i.e. have some sort of regex to apply it only to specific files i.e. resource.h or all files *

Maybe, more generally and not only for these options, we should be able to specify formating for specific files?
Something like what we already do for different languages maybe?

[mkurdej]

@mydeveloperday, I think that the options added in the aforementioned PR are orthogonal to whether we should be able to specify formatting for specific files (that would need a fair amount of work probably).
Also, with the recently landed commit to inherit the config file from the parent, one could use these options only in the directory with resource.h-like files.
In other words, I'd rather see your PR landed sooner than later (and pretty much as is, modulo review comments).