[MLIR][OpenMP] Add omp.target_triples attribute to the OffloadModuleInterface

[skatrak]

The OffloadModuleInterface holds getter/setter methods to access OpenMP dialect module-level discardable attributes used to hold general OpenMP compilation information.

This patch adds the omp.target_triples attribute, which is intended to hold the list of offloading target triples linked to the host module in which it appears. This attribute should be empty when omp.is_target_device=true.

[llvmbot]

@llvm/pr-subscribers-mlir-openmp
@llvm/pr-subscribers-flang-openmp

@llvm/pr-subscribers-mlir

Author: Sergio Afonso (skatrak)

Changes

The OffloadModuleInterface holds getter/setter methods to access OpenMP dialect module-level discardable attributes used to hold general OpenMP compilation information.

This patch adds the omp.target_triples attribute, which is intended to hold the list of offloading target triples linked to the host module in which it appears. This attribute should be empty when omp.is_target_device=true.

---

Full diff: https://github.com/llvm/llvm-project/pull/100154.diff

1 Files Affected:

• (modified) mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td (+28)

diff --git a/mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td b/mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td
index 385aa8b1b016a..9e62dcd9253d6 100644
--- a/mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td
+++ b/mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td
@@ -351,6 +351,34 @@ def OffloadModuleInterface : OpInterface<"OffloadModuleInterface"> {
       (ins "::mlir::omp::ClauseRequires":$clauses), [{}], [{
         $_op->setAttr(mlir::StringAttr::get($_op->getContext(), "omp.requires"),
           mlir::omp::ClauseRequiresAttr::get($_op->getContext(), clauses));
+      }]>,
+    InterfaceMethod<
+      /*description=*/[{
+        Get the omp.target_triples attribute on the operator if it's present and
+        return its value. If it doesn't exist, return an empty array by default.
+      }],
+      /*retTy=*/"::llvm::ArrayRef<::mlir::Attribute>",
+      /*methodName=*/"getTargetTriples",
+      (ins), [{}], [{
+        if (Attribute triplesAttr = $_op->getAttr("omp.target_triples"))
+          if (auto triples = ::llvm::dyn_cast<::mlir::ArrayAttr>(triplesAttr))
+            return triples.getValue();
+        return {};
+      }]>,
+    InterfaceMethod<
+      /*description=*/[{
+        Set the omp.target_triples attribute on the operation.
+      }],
+      /*retTy=*/"void",
+      /*methodName=*/"setTargetTriples",
+      (ins "::llvm::ArrayRef<::std::string>":$targetTriples), [{}], [{
+        auto names = ::llvm::to_vector(::llvm::map_range(
+            targetTriples, [&](::std::string str) -> ::mlir::Attribute {
+              return mlir::StringAttr::get($_op->getContext(), str);
+            }));
+        $_op->setAttr(
+            ::mlir::StringAttr::get($_op->getContext(), "omp.target_triples"),
+            ::mlir::ArrayAttr::get($_op->getContext(), names));
       }]>
   ];
 }

[Meinersbur]

LGTM

[skatrak]

I'm thinking that perhaps omp.offload_targets would be a better name for this attribute. Do you have any opinions @bhandarkar-pranav, @Meinersbur?