[libc][newheadergen]: PyYaml Version Update #100463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-libc Author: None (aaryanshukla) ChangesFull diff: https://github.com/llvm/llvm-project/pull/100463.diff 1 Files Affected:
diff --git a/libc/docs/dev/header_generation.rst b/libc/docs/dev/header_generation.rst
index 89036f1277b96..3b0fe50a91774 100644
--- a/libc/docs/dev/header_generation.rst
+++ b/libc/docs/dev/header_generation.rst
@@ -23,6 +23,7 @@ Instructions
Required Versions:
- Python Version: 3.11.8
+ - PyYaml Version: 5.1
1. Keep full-build mode on when building, otherwise headers will not be
generated.
|
RoseZhang03
reviewed
Jul 24, 2024
libc/docs/dev/header_generation.rst
Outdated
| @@ -23,6 +23,7 @@ Instructions | |||
|
|
|||
| Required Versions: | |||
| - Python Version: 3.11.8 | |||
| - PyYaml Version: 5.1 | |||
There was a problem hiding this comment.
Actually, change this to PyYAML
There was a problem hiding this comment.
Any luck bringing down the Python version? Python 3.8 worked previously, so increasing that is a lot of the problems.
There was a problem hiding this comment.
we support 3.6 as min version now if that works.
There was a problem hiding this comment.
@petrhosek let me know if this is good for Fuchsia
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: - a lot of builds had an issue using new headergen because they do not have PyYaml installed. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.