[compiler-rt][builtins] Upstream __isPlatformOrVariantPlatformVersionAtLeast() #100605
Conversation
…AtLeast(). Add `__isPlatformOrVariantPlatformVersionAtLeast()` which is used to check OS version availability from zippered libraries on macOS. This routine is needed for complete macCatalyst support in the Swift compiler.
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
Requesting review from @ahatanak. |
| int32_t __isPlatformOrVariantPlatformVersionAtLeast( | ||
| uint32_t Platform, uint32_t Major, uint32_t Minor, uint32_t Subminor, | ||
| uint32_t Platform2, uint32_t Major2, uint32_t Minor2, uint32_t Subminor2) { |
There was a problem hiding this comment.
Can you document what the Platform arguments are supposed to be? Where do those integer values come from? It seems like they should be the same as for __isPlatformVersionAtLeast, but that isn't documented either so these constants seem to come out of nowhere.
|
|
||
| int32_t check(uint32_t Major, uint32_t Minor, uint32_t Subminor) { | ||
| int32_t Result = | ||
| __isPlatformVersionAtLeast(PLATFORM_MACOS, Major, Minor, Subminor); | ||
| int32_t ResultVariant = __isPlatformOrVariantPlatformVersionAtLeast( | ||
| PLATFORM_MACOS, Major, Minor, Subminor, PLATFORM_IOS, 13, 0, 0); |
There was a problem hiding this comment.
Is there a reason for hardcoding the iOS version here?
|
@tshortli Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
tshortli
deleted the
upstream-is-platform-or-variant-platform-version-at-least
branch
Add
__isPlatformOrVariantPlatformVersionAtLeast()which is used to check OS version availability from zippered libraries on macOS. This routine is needed for complete macCatalyst support in the Swift compiler.