Skip to content

[DXIL] Remove extraneous include from DXILABI.h #100620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

bogner
Copy link
Contributor

@bogner bogner commented Jul 25, 2024

I'm not sure how an include of StringSwitch got here, but it isn't needed.

I'm not sure how an include of StringSwitch got here, but it isn't
needed.
@llvmbot
Copy link
Member

llvmbot commented Jul 25, 2024

@llvm/pr-subscribers-llvm-support
@llvm/pr-subscribers-backend-directx

@llvm/pr-subscribers-hlsl

Author: Justin Bogner (bogner)

Changes

I'm not sure how an include of StringSwitch got here, but it isn't needed.


Full diff: https://github.com/llvm/llvm-project/pull/100620.diff

2 Files Affected:

  • (modified) llvm/include/llvm/Frontend/HLSL/HLSLResource.h (+1)
  • (modified) llvm/include/llvm/Support/DXILABI.h (+1-1)
diff --git a/llvm/include/llvm/Frontend/HLSL/HLSLResource.h b/llvm/include/llvm/Frontend/HLSL/HLSLResource.h
index 4ed742b4129a2..989893bcaccec 100644
--- a/llvm/include/llvm/Frontend/HLSL/HLSLResource.h
+++ b/llvm/include/llvm/Frontend/HLSL/HLSLResource.h
@@ -13,6 +13,7 @@
 #ifndef LLVM_FRONTEND_HLSL_HLSLRESOURCE_H
 #define LLVM_FRONTEND_HLSL_HLSLRESOURCE_H
 
+#include "llvm/ADT/StringRef.h"
 #include "llvm/Support/DXILABI.h"
 
 namespace llvm {
diff --git a/llvm/include/llvm/Support/DXILABI.h b/llvm/include/llvm/Support/DXILABI.h
index d0bed4d5cf383..a2222eec09ba8 100644
--- a/llvm/include/llvm/Support/DXILABI.h
+++ b/llvm/include/llvm/Support/DXILABI.h
@@ -17,7 +17,7 @@
 #ifndef LLVM_SUPPORT_DXILABI_H
 #define LLVM_SUPPORT_DXILABI_H
 
-#include "llvm/ADT/StringSwitch.h"
+#include <cstdint>
 
 namespace llvm {
 namespace dxil {

@bogner bogner merged commit 2c435b8 into llvm:main Jul 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants