[libc++] Remove outdated setting of LIBCXX_CXX_ABI_LIBRARY_PATH #100631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LIBCXX_CXX_ABI_LIBRARY_PATH is used to determine the path of the ABI library in use. It shouldn't be necessary to set it explicitly in order to run the tests, since the test suite has its own configuration mechanism.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesLIBCXX_CXX_ABI_LIBRARY_PATH is used to determine the path of the ABI library in use. It shouldn't be necessary to set it explicitly in order to run the tests, since the test suite has its own configuration mechanism. Full diff: https://github.com/llvm/llvm-project/pull/100631.diff 1 Files Affected:
diff --git a/libcxx/test/CMakeLists.txt b/libcxx/test/CMakeLists.txt
index 001b29efcfefa..29f9ddc020702 100644
--- a/libcxx/test/CMakeLists.txt
+++ b/libcxx/test/CMakeLists.txt
@@ -1,12 +1,6 @@
include(HandleLitArguments)
add_subdirectory(tools)
-# By default, libcxx and libcxxabi share a library directory.
-if (NOT LIBCXX_CXX_ABI_LIBRARY_PATH)
- set(LIBCXX_CXX_ABI_LIBRARY_PATH "${LIBCXX_LIBRARY_DIR}" CACHE PATH
- "The path to libc++abi library.")
-endif()
-
set(AUTO_GEN_COMMENT "## Autogenerated by libcxx configuration.\n# Do not edit!")
set(SERIALIZED_LIT_PARAMS "# Lit parameters serialized here for llvm-lit to pick them up\n")
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIBCXX_CXX_ABI_LIBRARY_PATH is used to determine the path of the ABI library in use. It shouldn't be necessary to set it explicitly in order to run the tests, since the test suite has its own configuration mechanism.