Skip to content

[lldb] Remove python helper getCompilerBinary() #100660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions lldb/packages/Python/lldbsuite/test/lldbplatformutil.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,17 +266,13 @@ def getCompiler():
return module.getCompiler()


def getCompilerBinary():
"""Returns the compiler binary the test suite is running with."""
return getCompiler().split()[0]


def getCompilerVersion():
"""Returns a string that represents the compiler version.
Supports: llvm, clang.
"""
compiler = getCompilerBinary()
version_output = subprocess.check_output([compiler, "--version"], errors="replace")
version_output = subprocess.check_output(
[getCompiler(), "--version"], errors="replace"
)
m = re.search("version ([0-9.]+)", version_output)
if m:
return m.group(1)
Expand Down
4 changes: 0 additions & 4 deletions lldb/packages/Python/lldbsuite/test/lldbtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -1379,10 +1379,6 @@ def getCompiler(self):
"""Returns the compiler in effect the test suite is running with."""
return lldbplatformutil.getCompiler()

def getCompilerBinary(self):
"""Returns the compiler binary the test suite is running with."""
return lldbplatformutil.getCompilerBinary()

def getCompilerVersion(self):
"""Returns a string that represents the compiler version.
Supports: llvm, clang.
Expand Down
Loading