Skip to content

[BOLT][NFC] Fix test requirement #100867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2024
Merged

[BOLT][NFC] Fix test requirement #100867

merged 1 commit into from
Jul 27, 2024

Conversation

yota9
Copy link
Member

@yota9 yota9 commented Jul 27, 2024

Tests that are using instrumentation should have bolt-runtime in
requirements

Tests that are using instrumentation should have bolt-runtime in
requirements
@yota9 yota9 requested a review from aaupov as a code owner July 27, 2024 12:00
@yota9 yota9 added the BOLT label Jul 27, 2024
@yota9 yota9 requested a review from mtvec July 27, 2024 12:00
@llvmbot
Copy link
Member

llvmbot commented Jul 27, 2024

@llvm/pr-subscribers-bolt

Author: Vladislav Khmelevsky (yota9)

Changes

Tests that are using instrumentation should have bolt-runtime in
requirements


Full diff: https://github.com/llvm/llvm-project/pull/100867.diff

1 Files Affected:

  • (modified) bolt/test/AArch64/dummy-return.s (+3-1)
diff --git a/bolt/test/AArch64/dummy-return.s b/bolt/test/AArch64/dummy-return.s
index a446343161730..91f89dcb84762 100644
--- a/bolt/test/AArch64/dummy-return.s
+++ b/bolt/test/AArch64/dummy-return.s
@@ -1,4 +1,6 @@
-# REQUIRES: system-linux,target=aarch64{{.*}}
+# This test checks instrumentation of static binary on AArch64.
+
+# REQUIRES: system-linux,bolt-runtime,target=aarch64{{.*}}
 
 # RUN: llvm-mc -filetype=obj -triple aarch64-unknown-unknown %s -o %t.o
 # RUN: %clang %cflags %t.o -o %t.exe -Wl,-q -static

@yota9 yota9 requested a review from paschalis-mpeis July 27, 2024 12:07
@yota9 yota9 merged commit 803eaf2 into llvm:main Jul 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants