-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[libclang/python] Export all enums #100941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-clang Author: Jannick Kremer (DeinAlptraum) ChangesThis resolves #48212 and also adds the remaining unexposed Enums Full diff: https://github.com/llvm/llvm-project/pull/100941.diff 1 Files Affected:
diff --git a/clang/bindings/python/clang/cindex.py b/clang/bindings/python/clang/cindex.py
index be024da5e005c..d9009a8666338 100644
--- a/clang/bindings/python/clang/cindex.py
+++ b/clang/bindings/python/clang/cindex.py
@@ -4077,6 +4077,7 @@ def function_exists(self, name):
conf = Config()
__all__ = [
+ "AccessSpecifier",
"AvailabilityKind",
"BinaryOperator",
"Config",
@@ -4087,12 +4088,16 @@ def function_exists(self, name):
"CursorKind",
"Cursor",
"Diagnostic",
+ "ExceptionSpecificationKind",
"File",
"FixIt",
"Index",
"LinkageKind",
+ "RefQualifierKind",
"SourceLocation",
"SourceRange",
+ "StorageClass",
+ "TemplateArgumentKind",
"TLSKind",
"TokenKind",
"Token",
|
@Endilll can I ask you for a review again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think __all__
can be made a tuple instead, but it's not necessarily in the scope of this PR.
Could you also merge please? (or are you waiting for something else?) Also looked at the docs and it explicitly mentions that |
@DeinAlptraum Can you merge @tbaederr CI for this patch has failed due to unrelated failure that is likely to be connected to your work:
This is the second time during the past 7 days that I see |
c400783
to
4b1322b
Compare
That should be fixed already, I assume this is using an old version of the test. |
Sure, but it's annoying then you make a branch from |
This may be my fault, I don't remember if I pulled main before branching for this PR, especially seeing how my last PR also had unrelated test failures |
This resolves #48212 and also adds the remaining unexposed Enums