[NFC] fix build failure #100993
Merged
[NFC] fix build failure #100993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
llvm:analysis
|
@llvm/pr-subscribers-llvm-analysis Author: Chen Zheng (chenzheng1030) ChangesFix the build failure caused by #94944 Fixes #100296 Full diff: https://github.com/llvm/llvm-project/pull/100993.diff 1 Files Affected:
diff --git a/llvm/lib/Analysis/ConstantFolding.cpp b/llvm/lib/Analysis/ConstantFolding.cpp
index df75745645e049..ff30fece5fce93 100644
--- a/llvm/lib/Analysis/ConstantFolding.cpp
+++ b/llvm/lib/Analysis/ConstantFolding.cpp
@@ -1784,8 +1784,8 @@ Constant *ConstantFoldFP(double (*NativeFP)(double), const APFloat &V,
}
#if defined(HAS_IEE754_FLOAT128) && defined(HAS_LOGF128)
-Constant *ConstantFoldFP128(long double (*NativeFP)(long double),
- const APFloat &V, Type *Ty) {
+Constant *ConstantFoldFP128(float128 (*NativeFP)(float128), const APFloat &V,
+ Type *Ty) {
llvm_fenv_clearexcept();
float128 Result = NativeFP(V.convertToQuad());
if (llvm_fenv_testexcept()) {
|
arsenm
approved these changes
Jul 29, 2024
|
Any thoughts about picking this to the LLVM 19 release branch? It seems relatively harmless and fixes a build error. |
I agree (and had someone in Gentoo ping me about it), so I've requested the backport in the linked bug. |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Oct 16, 2024
Fix the build failure caused by llvm#94944 Fixes llvm#100296 (cherry picked from commit 40b4fd7)
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Oct 29, 2024
Fix the build failure caused by llvm#94944 Fixes llvm#100296 (cherry picked from commit 40b4fd7)
GZGavinZhao
pushed a commit
to GZGavinZhao/rocm-llvm-project
that referenced
this pull request
May 13, 2025
Fix the build failure caused by llvm#94944 Fixes llvm#100296 (cherry picked from commit 40b4fd7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the build failure caused by #94944
Fixes #100296