Skip to content

[libc][bazel] Remove tid tests from bazel #101109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

michaelrj-google
Copy link
Contributor

In patch #100915 the tid code
was reverted. The bazel build wasn't updated, leaving some broken
targets. This patch fixes those.

In patch llvm#100915 the tid code
was reverted. The bazel build wasn't updated, leaving some broken
targets. This patch fixes those.
@llvmbot llvmbot added libc bazel "Peripheral" support tier build system: utils/bazel labels Jul 30, 2024
@llvmbot
Copy link
Member

llvmbot commented Jul 30, 2024

@llvm/pr-subscribers-libc

Author: Michael Jones (michaelrj-google)

Changes

In patch #100915 the tid code
was reverted. The bazel build wasn't updated, leaving some broken
targets. This patch fixes those.


Full diff: https://github.com/llvm/llvm-project/pull/101109.diff

2 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/BUILD.bazel (-30)
  • (modified) utils/bazel/llvm-project-overlay/libc/test/src/unistd/BUILD.bazel (-7)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 5294351190d19..253b89216a88f 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -1077,22 +1077,6 @@ libc_support_library(
     ],
 )
 
-libc_support_library(
-    name = "__support_osutil_pid",
-    srcs = ["src/__support/OSUtil/linux/pid.cpp"],
-    hdrs = ["src/__support/OSUtil/pid.h"],
-    target_compatible_with = select({
-        "@platforms//os:linux": [],
-        "//conditions:default": ["@platforms//:incompatible"],
-    }),
-    deps = [
-        ":__support_macros_attributes",
-        ":__support_macros_optimization",
-        ":__support_osutil_syscall",
-        ":types_pid_t",
-    ],
-)
-
 libc_support_library(
     name = "__support_stringutil",
     srcs = glob(["src/__support/StringUtil/tables/**/*.h"]) + [
@@ -3043,20 +3027,6 @@ libc_function(
     ],
 )
 
-libc_function(
-    name = "getpid",
-    srcs = ["src/unistd/linux/getpid.cpp"],
-    hdrs = ["src/unistd/getpid.h"],
-    deps = [
-        ":__support_common",
-        ":__support_macros_config",
-        ":__support_osutil_pid",
-        ":__support_osutil_syscall",
-        ":errno",
-        ":types_pid_t",
-    ],
-)
-
 libc_function(
     name = "getppid",
     srcs = ["src/unistd/linux/getppid.cpp"],
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/unistd/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/unistd/BUILD.bazel
index 4549fa2a193fc..66d8ddb0a67eb 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/unistd/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/unistd/BUILD.bazel
@@ -261,13 +261,6 @@ libc_test(
 #     ],
 # )
 
-libc_test(
-    name = "getpid_test",
-    srcs = ["getpid_test.cpp"],
-    libc_function_deps = [
-        "//libc:getpid",
-    ],
-)
 
 libc_test(
     name = "getppid_test",

@MaskRay MaskRay merged commit ee6d932 into llvm:main Jul 30, 2024
8 checks passed
@michaelrj-google michaelrj-google deleted the libcPidBazelFix branch July 30, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel libc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants