[analyzer][NFC] Prune a very obsolete comment about CoreEngine #101173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once upon a time, a long time (16 years) ago there were two classes called `GREngineImpl` and `template <class CHECKER> GrEngine`. As the years passed, they were merged into a single class that went through several renames, but this comment still preserved the memory of their old relationship... until now.
|
This is a very trivial commit that just deletes the apparently obsolete parts of this comment. I kept the first two sentences which are probably still relevant and provide a very minimal description of this class. I'm opening this review to see whether anyone has more to say about |
steakhal
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time, a long time (16 years) ago there were two classes called
GREngineImplandtemplate <class CHECKER> GrEngine. As the years passed, they were merged into a single class that went through several renames, but this comment still preserved the memory of their old relationship... until now.