-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[MLIR][OpenMP] NFC: Sort clauses alphabetically (1/2) #101193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This patch sorts the clause lists for the following OpenMP operations: - omp.parallel - omp.teams - omp.sections - omp.wsloop - omp.distribute - omp.task This change results in the reordering of operation arguments, so impacted unit tests are updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It is really good to see all of these code quality and maintainability improvements you have been doing. The combined impact is large.
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/116/builds/1938 Here is the relevant piece of the build log for the reference:
|
This patch sorts the clause lists for the following OpenMP operations:
This change results in the reordering of operation arguments, so impacted unit tests are updated accordingly.