-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[NFC][LLVM] Add RealtimeSanitizer LLVM code owners #101231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC][LLVM] Add RealtimeSanitizer LLVM code owners #101231
Conversation
CC Reviewers @vitalybuka @MaskRay @davidtrevelyan Because we don't have commiter access, not sure if this should just be closed! I defer to the reviewers if adding this in is appropriate or not. Thanks as always. |
llvm/CODE_OWNERS.TXT
Outdated
@@ -263,3 +263,7 @@ D: C-SKY backend (lib/Target/CSKY/*) | |||
N: Ilia Diachkov | |||
E: [email protected] | |||
D: SPIR-V backend (lib/Target/SPIRV/*) | |||
|
|||
N: Christopher Apple, David Trevelyan | |||
E: [email protected], [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use an email address for contribution instead of realtime.sanitizer
, which might forward to you, but are not associated with any commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the latest version!
I don't know if this process is still relevant https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access |
Thanks for that link @vitalybuka! Do you think it's appropriate at this stage to apply for commit access? I have a couple commits, and only one large one (the compiler-rt work for rtsan). With a few additional big changes needed for the first version of rtsan. I defer to your expertise, seeing as you're the one I've interacted the most with on PRs. I do not want to apply "too early" if it is inappropriate. Thank you for any advice. |
https://discourse.llvm.org/t/rfc-new-criteria-for-commit-access/76290/81 We can try proceed as-is, without commiter, and you can apply when you think access is beneficial to you. |
Sounds good. I think perhaps once the main pieces of rtsan have landed and are stable, that would be a good time to apply. |
Split from #100596