[SandboxIR] Implement SIToFPInst #101374
Merged
[SandboxIR] Implement SIToFPInst #101374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vporpo
requested review from
slackito,
echristo,
alinas,
tschuett,
aeubanks,
tmsri and
Sterling-Augustine
aeubanks
reviewed
Jul 31, 2024
| @@ -1378,6 +1380,27 @@ class CastInst : public Instruction { | |||
| #endif | |||
| }; | |||
|
|
|||
| class SIToFPInst final : public CastInst { | |||
There was a problem hiding this comment.
I wonder if it's possible to do some CRTP magic to stamp out all of these instantiations much more succinctly. Let me mess around locally.
There was a problem hiding this comment.
Yeah that works. Do you want to create a PR for this?
There was a problem hiding this comment.
I could also try doing something similar for the tests, since there is a lot of repetition there too. The only downside is that if there is a failure the error reported won't be as easy to follow, but I doubt these tests will fail.
If we go this way, then the rest of the CastInst sub-classes can be a single PR which would be really nice.
Wdyt?
aeubanks
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements sandboxir::SIToFPInst which mirrors llvm::SIToFPInst.