Skip to content

[libc] Remove verbose printing from hdrgen tool #101376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

jhuber6
Copy link
Contributor

@jhuber6 jhuber6 commented Jul 31, 2024

Summary:
This fills the terminal with information already present from the
add_custom_command(COMMENT ...) field, so it breaks everything into
new lines. Remove this print to clean that up.

@llvmbot
Copy link
Member

llvmbot commented Jul 31, 2024

@llvm/pr-subscribers-libc

Author: Joseph Huber (jhuber6)

Changes

Summary:
This fills the terminal with information already present from the
add_custom_command(COMMENT ...) field, so it breaks everything into
new lines. Remove this print to clean that up.


Full diff: https://github.com/llvm/llvm-project/pull/101376.diff

1 Files Affected:

  • (modified) libc/newhdrgen/yaml_to_classes.py (-3)
diff --git a/libc/newhdrgen/yaml_to_classes.py b/libc/newhdrgen/yaml_to_classes.py
index d3bdfde2e2a22..e2d1ee4de494f 100644
--- a/libc/newhdrgen/yaml_to_classes.py
+++ b/libc/newhdrgen/yaml_to_classes.py
@@ -252,9 +252,6 @@ def main(
         with open(output_file_path, "w") as f:
             f.write(header_str)
 
-    print(f"Generated header file: {output_file_path}")
-
-
 if __name__ == "__main__":
     parser = argparse.ArgumentParser(description="Generate header files from YAML")
     parser.add_argument(

Summary:
This fills the terminal with information already present from the
`add_custom_command(COMMENT ...)` field, so it breaks everything into
new lines. Remove this print to clean that up.
@jhuber6 jhuber6 merged commit 6d40580 into llvm:main Aug 1, 2024
3 of 4 checks passed
@jhuber6 jhuber6 deleted the RemovePrinting branch October 14, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants