Skip to content

[LVI][NFC] Delete an outdated comment #101504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

pfusik
Copy link
Contributor

@pfusik pfusik commented Aug 1, 2024

Transitioned from inheritance to has-a relationship in 9db7948

Transitioned from inheritance to has-a relationship in 9db7948
@pfusik pfusik requested a review from nikic as a code owner August 1, 2024 15:36
@llvmbot llvmbot added the llvm:analysis Includes value tracking, cost tables and constant folding label Aug 1, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 1, 2024

@llvm/pr-subscribers-llvm-analysis

Author: Piotr Fusik (pfusik)

Changes

Transitioned from inheritance to has-a relationship in 9db7948


Full diff: https://github.com/llvm/llvm-project/pull/101504.diff

1 Files Affected:

  • (modified) llvm/lib/Analysis/LazyValueInfo.cpp (+1-3)
diff --git a/llvm/lib/Analysis/LazyValueInfo.cpp b/llvm/lib/Analysis/LazyValueInfo.cpp
index 4c023ed5ed8f0..310a7eafc8150 100644
--- a/llvm/lib/Analysis/LazyValueInfo.cpp
+++ b/llvm/lib/Analysis/LazyValueInfo.cpp
@@ -360,9 +360,7 @@ class LazyValueInfoAnnotatedWriter : public AssemblyAnnotationWriter {
                             formatted_raw_ostream &OS) override;
 };
 } // namespace
-// The actual implementation of the lazy analysis and update.  Note that the
-// inheritance from LazyValueInfoCache is intended to be temporary while
-// splitting the code and then transitioning to a has-a relationship.
+// The actual implementation of the lazy analysis and update.
 class LazyValueInfoImpl {
 
   /// Cached results from previous queries

@pfusik pfusik requested a review from preames August 1, 2024 15:37
@pfusik pfusik merged commit 60a7d33 into llvm:main Aug 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm:analysis Includes value tracking, cost tables and constant folding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants