Skip to content

[libc] created tan function fuzzer #101570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

RoseZhang03
Copy link
Contributor

Also edited file header formatting on sin_fuz and cos_fuzz

Also edited file header formatting on sin_fuz and cos_fuzz
@llvmbot
Copy link
Member

llvmbot commented Aug 1, 2024

@llvm/pr-subscribers-libc

Author: None (RoseZhang03)

Changes

Also edited file header formatting on sin_fuz and cos_fuzz


Full diff: https://github.com/llvm/llvm-project/pull/101570.diff

4 Files Affected:

  • (modified) libc/fuzzing/math/CMakeLists.txt (+9)
  • (modified) libc/fuzzing/math/cos_fuzz.cpp (+1-1)
  • (modified) libc/fuzzing/math/sin_fuzz.cpp (+1-1)
  • (added) libc/fuzzing/math/tan_fuzz.cpp (+40)
diff --git a/libc/fuzzing/math/CMakeLists.txt b/libc/fuzzing/math/CMakeLists.txt
index 7faf8fd53c849..31336fa3e49f3 100644
--- a/libc/fuzzing/math/CMakeLists.txt
+++ b/libc/fuzzing/math/CMakeLists.txt
@@ -79,3 +79,12 @@ add_libc_fuzzer(
   DEPENDS
     libc.src.math.cos
 )
+
+add_libc_fuzzer(
+  tan_fuzz
+  NEED_MPFR
+  SRCS
+    tan_fuzz.cpp
+  DEPENDS
+    libc.src.math.tan
+)
diff --git a/libc/fuzzing/math/cos_fuzz.cpp b/libc/fuzzing/math/cos_fuzz.cpp
index e26687d7f6ea8..3e4ad659fd3a5 100644
--- a/libc/fuzzing/math/cos_fuzz.cpp
+++ b/libc/fuzzing/math/cos_fuzz.cpp
@@ -1,4 +1,4 @@
-//===-- cos_fuzz.cpp ----------------------------------------------------===//
+//===-- cos_fuzz.cpp ------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
diff --git a/libc/fuzzing/math/sin_fuzz.cpp b/libc/fuzzing/math/sin_fuzz.cpp
index 0293afb062839..009b9f2080298 100644
--- a/libc/fuzzing/math/sin_fuzz.cpp
+++ b/libc/fuzzing/math/sin_fuzz.cpp
@@ -1,4 +1,4 @@
-//===-- sin_fuzz.cpp ----------------------------------------------------===//
+//===-- sin_fuzz.cpp ------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
diff --git a/libc/fuzzing/math/tan_fuzz.cpp b/libc/fuzzing/math/tan_fuzz.cpp
new file mode 100644
index 0000000000000..700ebb80974c8
--- /dev/null
+++ b/libc/fuzzing/math/tan_fuzz.cpp
@@ -0,0 +1,40 @@
+//===-- tan_fuzz.cpp ------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+///
+/// Fuzzing test for llvm-libc tan implementation.
+///
+//===----------------------------------------------------------------------===//
+
+#include "src/math/tan.h"
+#include <math.h>
+#include <mpfr.h>
+
+extern "C" int LLVMFuzzerTestOneInput(const double x) {
+  // remove NaN and inf as preconditions
+  if (isnan(x))
+    return 0;
+  if (isinf(x))
+    return 0;
+  // signed zeros already tested in unit tests
+  if (signbit(x) && x == 0.0)
+    return 0;
+  mpfr_t input;
+  mpfr_init2(input, 53);
+  mpfr_set_d(input, x, MPFR_RNDN);
+  int output = mpfr_tan(input, input, MPFR_RNDN);
+  mpfr_subnormalize(input, output, MPFR_RNDN);
+  double to_compare = mpfr_get_d(input, MPFR_RNDN);
+
+  double result = LIBC_NAMESPACE::tan(x);
+
+  if (result != to_compare)
+    __builtin_trap();
+
+  mpfr_clear(input);
+  return 0;
+}

@RoseZhang03 RoseZhang03 requested a review from lntue August 1, 2024 22:18
Copy link
Contributor

@michaelrj-google michaelrj-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RoseZhang03 RoseZhang03 merged commit 0142bd6 into llvm:main Aug 1, 2024
6 of 7 checks passed
@RoseZhang03 RoseZhang03 deleted the rosezhang24 branch August 1, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants