Skip to content

[libc][math][c23] removing dfmal for riscv #101719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aaryanshukla
Copy link
Contributor

No description provided.

@llvmbot llvmbot added the libc label Aug 2, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 2, 2024

@llvm/pr-subscribers-libc

Author: None (aaryanshukla)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/101719.diff

1 Files Affected:

  • (modified) libc/config/linux/riscv/entrypoints.txt (+1-1)
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 771f169332fcb..9091012e45759 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -387,7 +387,7 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.coshf
     libc.src.math.cospif
     libc.src.math.daddl
-    libc.src.math.dfmal
+    #libc.src.math.dfmal
     libc.src.math.dmull
     libc.src.math.dsqrtl
     libc.src.math.dsubl

@aaryanshukla aaryanshukla changed the title [libc][math][c23] removing dfmal for riscv ` [libc][math][c23] removing dfmal for riscv Aug 2, 2024
@mikhailramalho
Copy link
Member

Can you try to fix the issue instead?

@aaryanshukla
Copy link
Contributor Author

Yes, getting a fix right now

@overmighty
Copy link
Member

It's the same issue as in #101720. Except in this case, I'm not sure if the test code is doing what it was meant to. It's converting from StorageType to InType instead of bit-casting.

@overmighty
Copy link
Member

Closing since #101763 was merged instead.

@overmighty overmighty closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants