Skip to content

[libc++] mark P0645 as complete #101852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2024
Merged

[libc++] mark P0645 as complete #101852

merged 1 commit into from
Aug 4, 2024

Conversation

h-vetinari
Copy link
Contributor

Now that #98275 has been merged, the footnote for P0645 has become obsolete. I don't know if people prefer to just remove the footnote, or whether to keep it (to note the history), and whether to increment the "First version". I've made a suggestion, but I don't have a strong opinion - it should just be cleaned up one way or another.

CC @mordante @ldionne

@h-vetinari h-vetinari requested a review from a team as a code owner August 3, 2024 21:56
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Aug 3, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 3, 2024

@llvm/pr-subscribers-libcxx

Author: None (h-vetinari)

Changes

Now that #98275 has been merged, the footnote for P0645 has become obsolete. I don't know if people prefer to just remove the footnote, or whether to keep it (to note the history), and whether to increment the "First version". I've made a suggestion, but I don't have a strong opinion - it should just be cleaned up one way or another.

CC @mordante @ldionne


Full diff: https://github.com/llvm/llvm-project/pull/101852.diff

2 Files Affected:

  • (modified) libcxx/docs/Status/Cxx20.rst (+2-2)
  • (modified) libcxx/docs/Status/Cxx20Papers.csv (+1-1)
diff --git a/libcxx/docs/Status/Cxx20.rst b/libcxx/docs/Status/Cxx20.rst
index b76e30fbb3712..21755d7bd4820 100644
--- a/libcxx/docs/Status/Cxx20.rst
+++ b/libcxx/docs/Status/Cxx20.rst
@@ -41,8 +41,8 @@ Paper Status
 .. note::
 
    .. [#note-P0591] P0591: The changes in [mem.poly.allocator.mem] are missing.
-   .. [#note-P0645] P0645: The paper is implemented but still marked as an incomplete feature
-      (the feature-test macro is not set).
+   .. [#note-P0645] P0645: The implementation was largely complete since Clang 14,
+      but the feature-test macro was not set.
    .. [#note-P0966] P0966: It was previously erroneously marked as complete in version 8.0. See `bug 45368 <https://llvm.org/PR45368>`__.
    .. [#note-P0619] P0619: Only sections D.8, D.9, D.10 and D.13 are implemented. Sections D.4, D.7, D.11, and D.12 remain undone.
    .. [#note-P0883.1] P0883: shared_ptr and floating-point changes weren't applied as they themselves aren't implemented yet.
diff --git a/libcxx/docs/Status/Cxx20Papers.csv b/libcxx/docs/Status/Cxx20Papers.csv
index cd9902c86bcd4..c6587d2e82970 100644
--- a/libcxx/docs/Status/Cxx20Papers.csv
+++ b/libcxx/docs/Status/Cxx20Papers.csv
@@ -103,7 +103,7 @@
 "`P0466R5 <https://wg21.link/P0466R5>`__","Layout-compatibility and Pointer-interconvertibility Traits","Cologne","","",""
 "`P0553R4 <https://wg21.link/P0553R4>`__","Bit operations","Cologne","|Complete|","9.0",""
 "`P0631R8 <https://wg21.link/P0631R8>`__","Math Constants","Cologne","|Complete|","11.0",""
-"`P0645R10 <https://wg21.link/P0645R10>`__","Text Formatting","Cologne","|Complete| [#note-P0645]_","14.0",""
+"`P0645R10 <https://wg21.link/P0645R10>`__","Text Formatting","Cologne","|Complete| [#note-P0645]_","19.0",""
 "`P0660R10 <https://wg21.link/P0660R10>`__","Stop Token and Joining Thread, Rev 10.","Cologne","|Complete| [#note-P0660]_","18.0",""
 "`P0784R7 <https://wg21.link/P0784R7>`__","More constexpr containers","Cologne","|Complete|","12.0",""
 "`P0980R1 <https://wg21.link/P0980R1>`__","Making std::string constexpr","Cologne","|Complete|","15.0",""

Copy link
Member

@mordante mordante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! This was an omission on my part. I think it makes sense to keep a note, old versions of libc++ are still used. I only prefer to change the wording a bit more "it's fine starting from libc++14".

@mordante mordante merged commit 0edafc4 into llvm:main Aug 4, 2024
54 of 56 checks passed
@h-vetinari h-vetinari deleted the format branch August 4, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants