Skip to content

Fix some X86 tests #101944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix some X86 tests #101944

merged 1 commit into from
Aug 5, 2024

Conversation

JonPsson1
Copy link
Contributor

extractelement-shuffle.ll: Test for bugfix in DAGCombiner, moved to Generic.

2010-07-06-DbgCrash.ll and 2006-10-02-BoolRetCrash.ll: Bugfixes in X86, run tests with X86 backend.

@llvmbot
Copy link
Member

llvmbot commented Aug 5, 2024

@llvm/pr-subscribers-backend-x86

Author: Jonas Paulsson (JonPsson1)

Changes

extractelement-shuffle.ll: Test for bugfix in DAGCombiner, moved to Generic.

2010-07-06-DbgCrash.ll and 2006-10-02-BoolRetCrash.ll: Bugfixes in X86, run tests with X86 backend.


Full diff: https://github.com/llvm/llvm-project/pull/101944.diff

3 Files Affected:

  • (renamed) llvm/test/CodeGen/Generic/extractelement-shuffle.ll (-1)
  • (modified) llvm/test/CodeGen/X86/2006-10-02-BoolRetCrash.ll (+1-2)
  • (modified) llvm/test/CodeGen/X86/2010-07-06-DbgCrash.ll (+1-2)
diff --git a/llvm/test/CodeGen/X86/extractelement-shuffle.ll b/llvm/test/CodeGen/Generic/extractelement-shuffle.ll
similarity index 95%
rename from llvm/test/CodeGen/X86/extractelement-shuffle.ll
rename to llvm/test/CodeGen/Generic/extractelement-shuffle.ll
index 1b04c41d5c6fe..d1ba9a845800d 100644
--- a/llvm/test/CodeGen/X86/extractelement-shuffle.ll
+++ b/llvm/test/CodeGen/Generic/extractelement-shuffle.ll
@@ -1,5 +1,4 @@
 ; RUN: llc < %s
-; REQUIRES: default_triple
 
 ; Examples that exhibits a bug in DAGCombine.  The case is triggered by the
 ; following program.  The bug is DAGCombine assumes that the bit convert
diff --git a/llvm/test/CodeGen/X86/2006-10-02-BoolRetCrash.ll b/llvm/test/CodeGen/X86/2006-10-02-BoolRetCrash.ll
index 609dbc155ed91..3b59c11c06684 100644
--- a/llvm/test/CodeGen/X86/2006-10-02-BoolRetCrash.ll
+++ b/llvm/test/CodeGen/X86/2006-10-02-BoolRetCrash.ll
@@ -1,6 +1,5 @@
-; RUN: llc < %s 
+; RUN: llc -march=x86 < %s
 ; PR933
-; REQUIRES: default_triple
 
 define fastcc i1 @test() {
         ret i1 true
diff --git a/llvm/test/CodeGen/X86/2010-07-06-DbgCrash.ll b/llvm/test/CodeGen/X86/2010-07-06-DbgCrash.ll
index e67ee3123ff1c..e7bdbca0e9427 100644
--- a/llvm/test/CodeGen/X86/2010-07-06-DbgCrash.ll
+++ b/llvm/test/CodeGen/X86/2010-07-06-DbgCrash.ll
@@ -1,5 +1,4 @@
-; RUN: llc -O0 -relocation-model pic < %s -o /dev/null
-; REQUIRES: default_triple
+; RUN: llc -mtriple=x86_64-- -O0 -relocation-model pic < %s -o /dev/null
 ; PR7545
 
 @.str = private constant [4 x i8] c"one\00", align 1 ; <ptr> [#uses=1]

Copy link
Collaborator

@RKSimon RKSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonPsson1 JonPsson1 merged commit f231d3d into llvm:main Aug 5, 2024
6 of 9 checks passed
@JonPsson1 JonPsson1 deleted the X86Tests branch August 5, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants