Skip to content

[WebAssembly] Fix assertion in LowerBUILD_VECTOR #101961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2024
Merged

[WebAssembly] Fix assertion in LowerBUILD_VECTOR #101961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2276,9 +2276,9 @@ SDValue WebAssemblyTargetLowering::LowerBUILD_VECTOR(SDValue Op,
};
} else {
size_t DestLaneSize = VecT.getVectorElementType().getFixedSizeInBits();
if (NumSplatLanes == 1 && (DestLaneSize == 32 || DestLaneSize == 64)) {
if (NumSplatLanes == 1 && Op->getOperand(0) == SplatValue &&
(DestLaneSize == 32 || DestLaneSize == 64)) {
// Could be selected to load_zero.
assert(SplatValue == Op->getOperand(0));
Result = DAG.getNode(ISD::SCALAR_TO_VECTOR, DL, VecT, SplatValue);
} else {
// Use a splat (which might be selected as a load splat)
Expand Down
14 changes: 14 additions & 0 deletions llvm/test/CodeGen/WebAssembly/simd-build-vector.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,20 @@ define <4 x float> @load_zero_lane_f32x4(ptr %addr.a, ptr %addr.b, ptr %addr.c,
ret <4 x float> %v.3
}

define <4 x float> @load_zero_undef_lane_f32x4(ptr %addr.a, ptr %addr.b) {
; CHECK-LABEL: load_zero_undef_lane_f32x4:
; CHECK: .functype load_zero_undef_lane_f32x4 (i32, i32) -> (v128)
; CHECK-NEXT: # %bb.0:
; CHECK-NEXT: v128.load32_splat $push0=, 0($0)
; CHECK-NEXT: v128.load32_lane $push1=, 0($1), $pop0, 3
; CHECK-NEXT: return $pop1
%a = load float, ptr %addr.a
%b = load float, ptr %addr.b
%v = insertelement <4 x float> undef, float %a, i32 1
%v.1 = insertelement <4 x float> %v, float %b, i32 3
ret <4 x float> %v.1
}

define <2 x double> @load_zero_lane_f64x2(ptr %addr.a, ptr %addr.b) {
; CHECK-LABEL: load_zero_lane_f64x2:
; CHECK: .functype load_zero_lane_f64x2 (i32, i32) -> (v128)
Expand Down
Loading