[SLP][NFC] Add a new test for store chains that mix different sizes of values #101979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-transforms Author: tcwzxx (tcwzxx) ChangesAdd a new test case for PR #101810 Full diff: https://github.com/llvm/llvm-project/pull/101979.diff 1 Files Affected:
diff --git a/llvm/test/Transforms/SLPVectorizer/X86/stores_mix_sizes.ll b/llvm/test/Transforms/SLPVectorizer/X86/stores_mix_sizes.ll
new file mode 100644
index 0000000000000..c571372e40d16
--- /dev/null
+++ b/llvm/test/Transforms/SLPVectorizer/X86/stores_mix_sizes.ll
@@ -0,0 +1,34 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt -S --passes=slp-vectorizer -mtriple=x86_64-unknown-linux < %s | FileCheck %s
+
+define void @test(ptr %p) {
+; CHECK-LABEL: define void @test(
+; CHECK-SAME: ptr [[P:%.*]]) {
+; CHECK-NEXT: [[ENTRY:.*:]]
+; CHECK-NEXT: [[IDX1:%.*]] = getelementptr i8, ptr [[P]], i64 1
+; CHECK-NEXT: [[IDX_64_9:%.*]] = getelementptr i64, ptr [[P]], i64 9
+; CHECK-NEXT: store i64 1, ptr [[IDX_64_9]], align 8
+; CHECK-NEXT: store <8 x i8> zeroinitializer, ptr [[IDX1]], align 4
+; CHECK-NEXT: ret void
+;
+entry:
+ %idx1 = getelementptr i8, ptr %p, i64 1
+ store i8 0, ptr %idx1, align 4
+ %idx.64.9 = getelementptr i64, ptr %p, i64 9
+ store i64 1, ptr %idx.64.9, align 8
+ %idx2 = getelementptr i8, ptr %p, i64 2
+ store i8 0, ptr %idx2, align 4
+ %idx3 = getelementptr i8, ptr %p, i64 3
+ store i8 0, ptr %idx3, align 4
+ %idx4 = getelementptr i8, ptr %p, i64 4
+ store i8 0, ptr %idx4, align 4
+ %idx5 = getelementptr i8, ptr %p, i64 5
+ store i8 0, ptr %idx5, align 4
+ %idx6 = getelementptr i8, ptr %p, i64 6
+ store i8 0, ptr %idx6, align 4
+ %idx7 = getelementptr i8, ptr %p, i64 7
+ store i8 0, ptr %idx7, align 4
+ %idx8 = getelementptr i8, ptr %p, i64 8
+ store i8 0, ptr %idx8, align 4
+ ret void
+}
|
| ; CHECK-NEXT: [[IDX1:%.*]] = getelementptr i8, ptr [[P]], i64 1 | ||
| ; CHECK-NEXT: [[IDX_64_9:%.*]] = getelementptr i64, ptr [[P]], i64 9 | ||
| ; CHECK-NEXT: store i64 1, ptr [[IDX_64_9]], align 8 | ||
| ; CHECK-NEXT: store <8 x i8> zeroinitializer, ptr [[IDX1]], align 4 |
There was a problem hiding this comment.
The check must be formed with the current version of the compiler. If it is vectorized already, your patch does nothing.
There was a problem hiding this comment.
This check is generated after the patch, so is the correct process to add a current version of the compiler test case (NFC) and then update this test case in the patch?
tcwzxx
force-pushed
the
slp-new-test-case
branch
from
70e73af to
38bfcff
Compare
Could you help me merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.