[SandboxIR][Tracker] Track creation of instructions #102013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vporpo
requested review from
slackito,
tschuett,
aeubanks and
Sterling-Augustine
aeubanks
approved these changes
Aug 5, 2024
tschuett
reviewed
Aug 5, 2024
llvm/lib/SandboxIR/SandboxIR.cpp
Outdated
| // Track creation of instructions. | ||
| auto &Tracker = getTracker(); | ||
| if (Tracker.isTracking() && isa<Instruction>(VPtr.get())) | ||
| Tracker.track(std::make_unique<CreateAndInsertInst>( |
There was a problem hiding this comment.
verbose version with dyn_cast instead of isa+cast
This patch adds tracking support for the creation of SandboxIR instructions. This allows us to undo the creation of instructions during revert(). Please note that we don't allow the creation of detached instructions, meaning that the instructions need to be inserted into a block upon creation. This is why the tracker class combines creation and insertion.
I added the note in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds tracking support for the creation of SandboxIR instructions. This allows us to undo the creation of instructions during revert().
Please note that we don't allow creation of detached instructions, meaning that the instructions need to be inserted into a block upon creation. This is why the tracker class combines creation and insertion.