[libc] Add support for 'features.h' when targeting the GPU #102037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `features.h` provides some information about the C library, provide this on the GPU so external users can tell if it's the LLVM C library.
jhuber6
requested review from
lntue,
michaelrj-google,
overmighty and
SchrodingerZhu
|
@llvm/pr-subscribers-libc Author: Joseph Huber (jhuber6) ChangesSummary: Full diff: https://github.com/llvm/llvm-project/pull/102037.diff 1 Files Affected:
diff --git a/libc/config/gpu/headers.txt b/libc/config/gpu/headers.txt
index 1d4038d5eb45a..f01edb308b01b 100644
--- a/libc/config/gpu/headers.txt
+++ b/libc/config/gpu/headers.txt
@@ -14,6 +14,7 @@ set(TARGET_PUBLIC_HEADERS
libc.include.stdio
libc.include.wchar
libc.include.uchar
+ libc.include.features
# Header for RPC extensions
libc.include.gpu_rpc
|
lntue
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
features.hprovides some information about the C library, provide thison the GPU so external users can tell if it's the LLVM C library.