Skip to content

[Test] Update clang/test/Modules/crash-vfs-include-pch.m #102080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cachemeifyoucan
Copy link
Collaborator

Avoid the driver error for mis-using a clang cc1 flag as driver flag in
the crash test.

Created using spr 1.3.5
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:modules C++20 modules and Clang Header Modules labels Aug 5, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 5, 2024

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-modules

Author: Steven Wu (cachemeifyoucan)

Changes

Avoid the driver error for mis-using a clang cc1 flag as driver flag in
the crash test.


Full diff: https://github.com/llvm/llvm-project/pull/102080.diff

1 Files Affected:

  • (modified) clang/test/Modules/crash-vfs-include-pch.m (+1-1)
diff --git a/clang/test/Modules/crash-vfs-include-pch.m b/clang/test/Modules/crash-vfs-include-pch.m
index 4c05a07d0f74d..9ca10020094b0 100644
--- a/clang/test/Modules/crash-vfs-include-pch.m
+++ b/clang/test/Modules/crash-vfs-include-pch.m
@@ -10,7 +10,7 @@
 
 // RUN: env FORCE_CLANG_DIAGNOSTICS_CRASH= TMPDIR=%t TEMP=%t TMP=%t \
 // RUN: not %clang %s -E -include-pch %t/out/pch-used.h.pch -fmodules -nostdlibinc \
-// RUN:     -fimplicit-module-maps -fbuiltin-headers-in-system-modules \
+// RUN:     -fimplicit-module-maps -Xclang -fbuiltin-headers-in-system-modules \
 // RUN:     -fmodules-cache-path=%t/cache -O0 -Xclang -fno-validate-pch \
 // RUN:     -isystem %S/Inputs/System/usr/include -o %t/output.E 2>&1 | FileCheck %s
 

@cachemeifyoucan cachemeifyoucan merged commit c826c07 into main Aug 6, 2024
10 checks passed
@cachemeifyoucan cachemeifyoucan deleted the users/cachemeifyoucan/spr/test-update-clangtestmodulescrash-vfs-include-pchm branch August 6, 2024 17:06
cachemeifyoucan added a commit to cachemeifyoucan/llvm-project that referenced this pull request Nov 7, 2024
Avoid the driver error for mis-using a clang cc1 flag as driver flag in
the crash test.

(cherry picked from commit c826c07)
cachemeifyoucan added a commit to swiftlang/llvm-project that referenced this pull request Nov 8, 2024
Avoid the driver error for mis-using a clang cc1 flag as driver flag in
the crash test.

(cherry picked from commit c826c07)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:modules C++20 modules and Clang Header Modules clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants