[NFC] Temporarily disable failing TableGen unit test. #102308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jurahul
commented
Aug 7, 2024
jurahul
commented
- This test was reported as failing in ASAN builds, with non-deterministic order of the error message and note expected.
- This is due to llvm::sort() being unstable.
- Temporarily disable the test while its been fixed.
- This test was reported as failing in ASAN builds, with non-deterministic order of the error message and note expected. - This is due to llvm::sort() being unstable. - Temporarily disable the test while its been fixed.
|
FYI, I will roll in the fix in my rework PR, disabling the test till that is ready. |
s-barannikov
approved these changes
Aug 7, 2024
|
@s-barannikov or @joker-eph can one of you merge this PR? |
|
Thanks @s-barannikov ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.