Skip to content

[ExpandVectorPredication] Be more precise reporting changes #102313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

rofirrim
Copy link
Collaborator

@rofirrim rofirrim commented Aug 7, 2024

This is used by PreISelIntrinsicLowering. With this change, PreISelIntrinsicLowering does not have to assume that there were changes just because we encountered a VP intrinsic.

This is used by PreISelIntrinsicLowering. With this change,
PreISelIntrinsicLowering does not have to assume that there were
changes just because we encountered a VP intrinsic.
@rofirrim rofirrim requested review from aengelke and simoll August 7, 2024 13:36
This way PreISelIntrinsicLowering can know whether the intrinsic
was effectively removed or just updated.
Copy link
Contributor

@aengelke aengelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rofirrim rofirrim merged commit e1a16cd into llvm:main Aug 9, 2024
7 checks passed
@rofirrim rofirrim deleted the expand-vector-vp-changes branch August 9, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants