[Modules] Fix cyclic module dependencies in clang #102348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
llvmbot
added
clang
|
@llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang Author: Steven Wu (cachemeifyoucan) ChangesBreakup the cyclic dependency in module 'Clang_Frontend': Full diff: https://github.com/llvm/llvm-project/pull/102348.diff 1 Files Affected:
diff --git a/clang/include/clang/Serialization/ObjectFilePCHContainerReader.h b/clang/include/clang/Serialization/ObjectFilePCHContainerReader.h
index 6281a3f428869..06778d25d7e52 100644
--- a/clang/include/clang/Serialization/ObjectFilePCHContainerReader.h
+++ b/clang/include/clang/Serialization/ObjectFilePCHContainerReader.h
@@ -9,7 +9,7 @@
#ifndef LLVM_CLANG_SERIALIZATION_OBJECTFILEPCHCONTAINERREADER_H
#define LLVM_CLANG_SERIALIZATION_OBJECTFILEPCHCONTAINERREADER_H
-#include "clang/Frontend/PCHContainerOperations.h"
+#include "clang/Serialization/PCHContainerOperations.h"
namespace clang {
/// A PCHContainerReader implementation that uses LLVM to
|
|
Maybe the next step is to get rid of |
cachemeifyoucan
changed the title
jansvoboda11
approved these changes
Aug 7, 2024
cachemeifyoucan
deleted the
users/cachemeifyoucan/spr/modules-fix-cyclic-dependencies-in-clang
branch
benlangmuir
pushed a commit
to benlangmuir/llvm-project
that referenced
this pull request
Mar 10, 2025
Breakup the cyclic dependency in module 'Clang_Frontend': Clang_Frontend -> Clang_Serialization -> Clang_Frontend (cherry picked from commit 61c0a6d)
benlangmuir
pushed a commit
to benlangmuir/llvm-project
that referenced
this pull request
Mar 10, 2025
Breakup the cyclic dependency in module 'Clang_Frontend': Clang_Frontend -> Clang_Serialization -> Clang_Frontend (cherry picked from commit 61c0a6d)
cyndyishida
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Mar 11, 2025
Breakup the cyclic dependency in module 'Clang_Frontend': Clang_Frontend -> Clang_Serialization -> Clang_Frontend (cherry picked from commit 61c0a6d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breakup the cyclic dependency in module 'Clang_Frontend':
Clang_Frontend -> Clang_Serialization -> Clang_Frontend