Skip to content

[scudo] Die when store is called on MapAllocatorNoCache objects. #102403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions compiler-rt/lib/scudo/standalone/secondary.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,11 @@ template <typename Config> class MapAllocatorNoCache {
return {};
}
void store(UNUSED Options Options, UNUSED uptr CommitBase,
UNUSED uptr CommitSize, UNUSED uptr BlockBegin, MemMapT MemMap) {
unmap(MemMap);
UNUSED uptr CommitSize, UNUSED uptr BlockBegin,
UNUSED MemMapT MemMap) {
// This should never be called since canCache always returns false.
UNREACHABLE(
"It is not valid to call store on MapAllocatorNoCache objects.");
}

bool canCache(UNUSED uptr Size) { return false; }
Expand Down
Loading