[update_llc_test_checks][AMDGPU] Update AMDGPU regexp in update_llc_test_checks.py #102480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est_checks.py Updating llvm/test/CodeGen/AMDGPU/GlobalISel/extractelement.ll with update_llc_test_checks.py ended with several kernels with no checks. Change-Id: Ib83e1fe830109431cb3cb26fb12d7960db4e2abf
|
@llvm/pr-subscribers-testing-tools Author: Juan Manuel Martinez Caamaño (jmmartinez) ChangesUpdating Llc's output contained the line ".amdgpu_hsa_kernel <funcname>" after the ".type <funcname>,@function" entry which was not considered by the regexp. Full diff: https://github.com/llvm/llvm-project/pull/102480.diff 1 Files Affected:
diff --git a/llvm/utils/UpdateTestChecks/asm.py b/llvm/utils/UpdateTestChecks/asm.py
index f150098eaaeef4..f05d8b89e73b93 100644
--- a/llvm/utils/UpdateTestChecks/asm.py
+++ b/llvm/utils/UpdateTestChecks/asm.py
@@ -52,6 +52,7 @@ class string:
ASM_FUNCTION_AMDGPU_RE = re.compile(
r"\.type\s+_?(?P<func>[^,\n]+),@function\n"
+ r"(^\s*\.amdgpu_hsa_kernel (?P=func)\n)?"
r'^_?(?P=func):(?:[ \t]*;+[ \t]*@"?(?P=func)"?)?\n'
r"(?P<body>.*?)\n" # (body of the function)
# This list is incomplete
|
arsenm
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
llvm/test/CodeGen/AMDGPU/GlobalISel/extractelement.llwithupdate_llc_test_checks.pyended with several kernels with no checks.Llc's output contained the line ".amdgpu_hsa_kernel " after the ".type ,@function" entry which was not considered by the regexp.